Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✏ Fix broken link in README file #442

Merged
merged 2 commits into from
Jan 26, 2025

Conversation

ebouchut
Copy link

@ebouchut ebouchut commented Nov 16, 2024

ℹ️ Since we switched the website engine to Mkdocs, the path of the URLs has changed:

  • /en/latest was dropped
  • the .html page suffix has been replaced with /

Source: Slack

@ebouchut ebouchut changed the title ✏ Fix/broken link in README file ✏ Fix broken link in README file Nov 16, 2024
@ebouchut ebouchut marked this pull request as draft November 17, 2024 09:32
@ebouchut ebouchut changed the base branch from main to dev November 17, 2024 09:33
@ebouchut ebouchut marked this pull request as ready for review November 17, 2024 09:33
Copy link
Contributor

@Sjoerd-Bo3 Sjoerd-Bo3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bjornoleh bjornoleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two links in this PR does work, approving based on that.

@bjornoleh bjornoleh merged commit b6fe250 into nightscout:dev Jan 26, 2025
1 check passed
This was referenced Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants