Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add automated certificate check and renewal workflows #451

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

bjornoleh
Copy link
Contributor

@bjornoleh bjornoleh commented Jan 11, 2025

  • Introduced check_certs.yml workflow to validate the presence and validity of distribution certificates, with options to renew or recreate certificates.
  • Updated build_trio.yml to integrate certificate checks as a dependency for the build job.
  • Enhanced validate_secrets.yml with clearer error messages for App Store Connect API authorization issues.
  • Modified create_certs.yml to allow workflow_call triggers.
  • Added check_and_renew_certificates lane in Fastlane for certificate validation and renewal.
  • Nuke certs only if repository variable ENABLE_NUKE_CERTS == 'true'
  • Set failure and output annotation if nuke_certs were skipped due to ENABLE_NUKE_CERTS != true

- Introduced `check_certs.yml` workflow to validate the presence and validity of distribution certificates, with options to renew or recreate certificates.
- Updated `build_trio.yml` to integrate certificate checks as a dependency for the build job.
- Enhanced `validate_secrets.yml` with clearer error messages for App Store Connect API authorization issues.
- Modified `create_certs.yml` to allow `workflow_call` triggers.
- Added `check_and_renew_certificates` lane in Fastlane for certificate validation and renewal.
@bjornoleh
Copy link
Contributor Author

bjornoleh commented Jan 11, 2025

This is also PRed to LoopKit/LoopWorkspace: LoopKit/LoopWorkspace#228

This PR might receive updates depending on feedback on the other PR.

Please reach out regarding testing on expired certificates, there might be scenarios we'd like to cover.

Edit: the workflow seems to be failing, please wait for confirmation that it is worthwhile to test this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant