feat: throw an error if Factories trait is not used in a KernelTestCase

.gitignore

@@ -4,7 +4,7 @@
 /.phpunit.cache
 /vendor/
 /bin/tools/*/vendor/
-/bin/tools/php-cs-fixer/composer.lock
+/bin/tools/csfixer
 /build/
 /.php-cs-fixer.cache
 /.phpunit.result.cache

.php-cs-fixer.dist.php

@@ -7,6 +7,17 @@
     \file_get_contents('https://raw.githubusercontent.com/zenstruck/.github/main/.php-cs-fixer.dist.php')
 );
 
+$finder = PhpCsFixer\Finder::create()
+    ->in([__DIR__.'/src', __DIR__.'/tests'])
+
+    // we don't want to use @test annotations, to prevent deprecations notices,
+    // which would make the .phpt test fail with recent PHPUnit versions
+    ->notName('KernelTestCaseUsingWithStoryWithoutFactoriesTraitTest.php')
+
+    // we want to keep the traits in "wrong order"
+    ->notName('KernelTestCaseWithBothTraitsInWrongOrderTest.php')
+;
+
 try {
     return require $file;
 } finally {

phpunit-10.xml.dist

@@ -18,6 +18,7 @@
         <testsuite name="main">
             <directory>tests</directory>
             <exclude>tests/Integration/Migration/ResetDatabaseWithMigrationTest.php</exclude>
+            <exclude>tests/Fixture</exclude>
         </testsuite>
         <testsuite name="migrate">
             <file>tests/Integration/Migration/ResetDatabaseWithMigrationTest.php</file>

phpunit-paratest.xml.dist

@@ -17,6 +17,7 @@
         <testsuite name="main">
             <directory>tests</directory>
             <exclude>tests/Integration/Migration/ResetDatabaseWithMigrationTest.php</exclude>
+            <exclude>tests/Fixture</exclude>
         </testsuite>
     </testsuites>
     <source ignoreSuppressionOfDeprecations="true">

phpunit.xml.dist

@@ -20,6 +20,7 @@
         <testsuite name="main">
             <directory>tests</directory>
             <exclude>tests/Integration/Migration/ResetDatabaseWithMigrationTest.php</exclude>
+            <exclude>tests/Fixture</exclude>
         </testsuite>
         <testsuite name="migrate">
             <file>tests/Integration/Migration/ResetDatabaseWithMigrationTest.php</file>

src/Configuration.php

@@ -101,6 +101,8 @@ public static function isBooted(): bool
     /** @param \Closure():self|self $configuration */
     public static function boot(\Closure|self $configuration): void
     {
+        //        self::throwIfComingFromKernelTestCaseWithoutFactoriesTrait();
+
         self::$instance = $configuration;
     }
 

src/Exception/FactoriesTraitNotUsed.php

@@ -0,0 +1,58 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * This file is part of the zenstruck/foundry package.
+ *
+ * (c) Kevin Bond <kevinbond@gmail.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Zenstruck\Foundry\Exception;
+
+use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
+use Zenstruck\Foundry\Test\Factories;
+
+/**
+ * @author Nicolas PHILIPPE <nikophil@gmail.com>
+ */
+final class FactoriesTraitNotUsed extends \LogicException
+{
+    /**
+     * @param class-string<KernelTestCase> $class
+     */
+    public function __construct(string $class)
+    {
+        parent::__construct(\sprintf('You must use the trait "%s" in "%s" in order to use Foundry.', Factories::class, $class));
+    }
+
+    public static function throwIfComingFromKernelTestCaseWithoutFactoriesTrait(): void
+    {
+        $backTrace = \debug_backtrace(\DEBUG_BACKTRACE_IGNORE_ARGS); // @phpstan-ignore ekinoBannedCode.function
+
+        foreach ($backTrace as $trace) {
+            if (
+                '->' === ($trace['type'] ?? null)
+                && isset($trace['class'])
+                && KernelTestCase::class !== $trace['class']
+                && \is_a($trace['class'], KernelTestCase::class, allow_string: true)
+                && !(new \ReflectionClass($trace['class']))->hasMethod('_bootFoundry')
+            ) {
+                self::throwIfClassDoesNotHaveFactoriesTrait($trace['class']);
+            }
+        }
+    }
+
+    /**
+     * @param class-string<KernelTestCase> $class
+     */
+    public static function throwIfClassDoesNotHaveFactoriesTrait(string $class): void
+    {
+        if (!(new \ReflectionClass($class))->hasMethod('_bootFoundry')) {
+            throw new self($class);
+        }
+    }
+}

src/ObjectFactory.php

@@ -11,6 +11,7 @@
 
 namespace Zenstruck\Foundry;
 
+use Zenstruck\Foundry\Exception\FactoriesTraitNotUsed;
 use Zenstruck\Foundry\Object\Instantiator;
 
 /**
@@ -43,6 +44,8 @@ abstract public static function class(): string;
      */
     public function create(callable|array $attributes = []): object
     {
+        FactoriesTraitNotUsed::throwIfComingFromKernelTestCaseWithoutFactoriesTrait();
+
         $parameters = $this->normalizeAttributes($attributes);
 
         foreach ($this->beforeInstantiate as $hook) {

src/PHPUnit/BuildStoryOnTestPrepared.php

@@ -16,6 +16,7 @@
 use PHPUnit\Event;
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
 use Zenstruck\Foundry\Attribute\WithStory;
+use Zenstruck\Foundry\Exception\FactoriesTraitNotUsed;
 
 /**
  * @internal
@@ -46,6 +47,8 @@ public function notify(Event\Test\Prepared $event): void
             throw new \InvalidArgumentException(\sprintf('The test class "%s" must extend "%s" to use the "%s" attribute.', $test->className(), KernelTestCase::class, WithStory::class));
         }
 
+        FactoriesTraitNotUsed::throwIfClassDoesNotHaveFactoriesTrait($test->className());
+
         foreach ($withStoryAttributes as $withStoryAttribute) {
             $withStoryAttribute->newInstance()->story::load();
         }

tests/Fixture/ForceFactoriesTraitUsage/KernelTestCaseUsingWithStoryWithoutFactoriesTraitTest.php

@@ -0,0 +1,27 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * This file is part of the zenstruck/foundry package.
+ *
+ * (c) Kevin Bond <kevinbond@gmail.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Fixture\ForceFactoriesTraitUsage;
+
+use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
+use Zenstruck\Foundry\Attribute\WithStory;
+use Zenstruck\Foundry\Tests\Fixture\Stories\ObjectStory;
+
+#[WithStory(ObjectStory::class)]
+final class KernelTestCaseUsingWithStoryWithoutFactoriesTraitTest extends KernelTestCase
+{
+    public function test_using_story_with_attribute_without_factories_trait_should_throw(): void
+    {
+        $this->expectNotToPerformAssertions();
+    }
+}

tests/Integration/ForceFactoriesTraitUsage/KernelTestCaseWithBothTraitsInWrongOrderTest.php

@@ -0,0 +1,46 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * This file is part of the zenstruck/foundry package.
+ *
+ * (c) Kevin Bond <kevinbond@gmail.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Zenstruck\Foundry\Tests\Integration\ForceFactoriesTraitUsage;
+
+use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
+use Zenstruck\Foundry\Test\Factories;
+use Zenstruck\Foundry\Test\ResetDatabase;
+use Zenstruck\Foundry\Tests\Fixture\Factories\Object1Factory;
+
+final class KernelTestCaseWithBothTraitsInWrongOrderTest extends KernelTestCase
+{
+    use ResetDatabase, Factories;
+
+    /**
+     * @test
+     */
+    public function should_not_throw(): void
+    {
+        Object1Factory::createOne();
+
+        $this->expectNotToPerformAssertions();
+    }
+
+    /**
+     * @test
+     */
+    public function should_not_throw_even_when_kernel_is_booted(): void
+    {
+        self::getContainer();
+
+        Object1Factory::createOne();
+
+        $this->expectNotToPerformAssertions();
+    }
+}

tests/Integration/ForceFactoriesTraitUsage/KernelTestCaseWithBothTraitsTest.php

@@ -0,0 +1,46 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * This file is part of the zenstruck/foundry package.
+ *
+ * (c) Kevin Bond <kevinbond@gmail.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Zenstruck\Foundry\Tests\Integration\ForceFactoriesTraitUsage;
+
+use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
+use Zenstruck\Foundry\Test\Factories;
+use Zenstruck\Foundry\Test\ResetDatabase;
+use Zenstruck\Foundry\Tests\Fixture\Factories\Object1Factory;
+
+final class KernelTestCaseWithBothTraitsTest extends KernelTestCase
+{
+    use Factories, ResetDatabase;
+
+    /**
+     * @test
+     */
+    public function should_not_throw(): void
+    {
+        Object1Factory::createOne();
+
+        $this->expectNotToPerformAssertions();
+    }
+
+    /**
+     * @test
+     */
+    public function should_not_throw_even_when_kernel_is_booted(): void
+    {
+        self::getContainer();
+
+        Object1Factory::createOne();
+
+        $this->expectNotToPerformAssertions();
+    }
+}

tests/Integration/ForceFactoriesTraitUsage/KernelTestCaseWithFactoriesTraitTest.php

@@ -0,0 +1,45 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * This file is part of the zenstruck/foundry package.
+ *
+ * (c) Kevin Bond <kevinbond@gmail.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Zenstruck\Foundry\Tests\Integration\ForceFactoriesTraitUsage;
+
+use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
+use Zenstruck\Foundry\Test\Factories;
+use Zenstruck\Foundry\Tests\Fixture\Factories\Object1Factory;
+
+final class KernelTestCaseWithFactoriesTraitTest extends KernelTestCase
+{
+    use Factories;
+
+    /**
+     * @test
+     */
+    public function should_not_throw(): void
+    {
+        Object1Factory::createOne();
+
+        $this->expectNotToPerformAssertions();
+    }
+
+    /**
+     * @test
+     */
+    public function should_not_throw_even_when_kernel_is_booted(): void
+    {
+        self::getContainer();
+
+        Object1Factory::createOne();
+
+        $this->expectNotToPerformAssertions();
+    }
+}

tests/Integration/ForceFactoriesTraitUsage/KernelTestCaseWithOnlyResetDatabaseTraitTest.php

@@ -0,0 +1,52 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * This file is part of the zenstruck/foundry package.
+ *
+ * (c) Kevin Bond <kevinbond@gmail.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Zenstruck\Foundry\Tests\Integration\ForceFactoriesTraitUsage;
+
+use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
+use Zenstruck\Foundry\Exception\FactoriesTraitNotUsed;
+use Zenstruck\Foundry\Test\ResetDatabase;
+use Zenstruck\Foundry\Tests\Fixture\Factories\Object1Factory;
+
+final class KernelTestCaseWithOnlyResetDatabaseTraitTest extends KernelTestCase
+{
+    use ResetDatabase;
+
+    /**
+     * @test
+     */
+    public function not_using_foundry_should_not_throw(): void
+    {
+        $this->expectNotToPerformAssertions();
+    }
+
+    /**
+     * @test
+     */
+    public function not_using_foundry_should_not_throw_even_when_container_is_used(): void
+    {
+        self::getContainer()->get('.zenstruck_foundry.configuration');
+
+        $this->expectNotToPerformAssertions();
+    }
+
+    /**
+     * @test
+     */
+    public function using_foundry_should_throw(): void
+    {
+        $this->expectException(FactoriesTraitNotUsed::class);
+
+        Object1Factory::createOne();
+    }
+}