Add optional callback ranch_transport:format_error/1
#354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juhlig
commented
Nov 18, 2024
essen
reviewed
Nov 18, 2024
|
Looks fine yes. |
|
Maybe have a test for the custom transport if we don't already. |
I think we don't. There is |
|
Wait, we have concuerror tests? 😳 Since when? That completely went by me 😅 |
|
Yes. #261 |
|
It's very basic for now: https://github.com/ninenines/ranch/blob/master/test/ranch_concuerror.erl |
juhlig
force-pushed
the
ranch_transport_format_error
branch
from
5de33d5 to
90da425
Compare
|
@essen added docs and a test and changed |
essen
reviewed
Jan 23, 2025
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #346.
No docs yet, wanted to see what you think of the implementation first. Will add more comments inline.