Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay my plan here is to take a multi stage approach to getting the latest hash_table8 moved into the project.
configure.py --bootstrap
fails onemhash/hash_table8.hpp
#2531Changes
#define unlink _unlink
but the compiler still viewed 'unlink' as a POSIX function. I created a function that injects the correct version of unlink depending on the platform.EXPECT_EQ(list.size(), 1);
makes sense, but the compiler doesn't like it. Ideally we would be matching all of our assertions to the exact type. But realisticallyEXPECT_EQ(list.size(), size_t(1));
andEXPECT_EQ(list.size(), 1u);
are going to be equivalent for small values.