Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add nepali locale #40

Merged
merged 3 commits into from
Jan 26, 2025

Conversation

sabin6969
Copy link
Contributor

Pull Request Checklist

What does this PR do?

Added Nepali locale support to the get_time_ago package.

Checklist

Code Changes

  • I have added new features to the package (support for nepali language)

Documentation

  • I have updated the README file or relevant documentation with the changes
  • I have added code usage examples or updated existing examples to reflect changes
  • I have updated the package version in the pubspec.yaml file

Testing

General Tests

  • The package correctly formats time differences into human-readable strings
  • The package supports dynamic updates (e.g., changing locales, thresholds)

Localization

  • The package supports all documented languages
  • Custom locales can be added and work as expected
  • Language fallback works correctly if a specific locale is missing

Custom Thresholds

  • Custom time thresholds are applied correctly
  • The package handles edge cases like just now, future dates, or extreme past dates

Error Handling

  • The package handles null or invalid inputs gracefully
  • Fallback behavior works for unexpected or incorrect configurations

Responsiveness

  • The package adapts to time-zone differences accurately
  • The formatting responds correctly to locale changes in the app

Performance

  • The package performs efficiently, even when processing frequent or large updates
  • Performance tests show no regressions

How did you verify your code works?

  • I have written unit tests covering the new features
  • I ran manual tests to verify time formatting for different locales and thresholds
  • I tested with various configurations (custom thresholds, language overrides)
  • All tests pass locally (flutter test)
    Test Cases
Demo.mp4

-->

@nixrajput nixrajput merged commit 8a547be into nixrajput:master Jan 26, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants