Bugfix release v1.2.1 #126
Conversation
This addresses issue #125.
CMakeLists.txt
Outdated
| @@ -23,7 +23,7 @@ option( strict_compile | |||
| # Compile flags | |||
| set( common_flags "-Wall" "-Wextra" "-Wpedantic" ) | |||
| set( strict_flags "-Werror" ) | |||
| set( release_flags "-O3" ) | |||
| set( release_flags "-O3" "-Wno-unknown-warning-option" ) | |||
There was a problem hiding this comment.
@nathangibson14 I'm not sure this is the right way to address #106 and #116. It solves the problem, but it may just be a cop-out.
|
@whaeck and @nathangibson14 Could you take a look at this Pull Request, please? |
|
Last chance to make a statement about this Pull Request. I've been waiting a month with no response. Please help out. |
| @@ -18,7 +18,11 @@ | |||
| #include "Log.hpp" | |||
| #include "utility.hpp" | |||
|
|
|||
|
|
|||
| #pragma GCC diagnostic push | |||
| #pragma GCC diagnostic ignored "-Wmaybe-uninitialized" | |||
There was a problem hiding this comment.
Might it be possible to tweak the offending lipservice code so that this isn't necessary? (I suppose I could go take a look myself.) Better a fundamental fix than diagnostic push/pop pragmas everywhere else that uses it.
There was a problem hiding this comment.
As you saw in #106, the lipservice code is valid and initialized. I do think think this is a GCC bug.
|
@jlconlin The CI seems to indicate a linker problem for gcc9. Did you look into that? |
I saw that there was a problem. I haven't been able to reproduce it on my own Mac. |
This Pull Request would create NJOY21 version 1.2.1.
This addresses a few issues.