Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regression test for #3810 #4608

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Add regression test for #3810 #4608

wants to merge 5 commits into from

Conversation

nlohmann
Copy link
Owner

Issue #3810 was fixed by merging #4597. This PR adds a regression test.

@nlohmann
✅ add regression test for #3810
fb895ba 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann nlohmann added this to the Release 3.11.4 milestone Jan 19, 2025
@coveralls
Copy link

coveralls commented Jan 19, 2025 •
edited
Loading

Coverage Status

coverage: 99.186%. remained the same
when pulling feb18d7 on regression-for-3810
into f06604f on develop.

@nlohmann nlohmann removed this from the Release 3.11.4 milestone Jan 19, 2025
@nlohmann nlohmann marked this pull request as draft January 19, 2025 18:15
@nlohmann
✅ add regression test for #3810
68c4905 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann
✅ add regression test for #3810
2db45cb 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann
✅ add regression test for #3810
821d7ef 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann nlohmann marked this pull request as ready for review January 23, 2025 08:27
@nlohmann
✅ add regression test for #3810
feb18d7 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann nlohmann added this to the Release 3.11.4 milestone Jan 23, 2025
@nlohmann nlohmann added the review needed It would be great if someone could review the proposed changes. label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmarr gregmarr gregmarr left review comments

Assignees
No one assigned
Labels
M review needed It would be great if someone could review the proposed changes. tests
Projects
None yet
Milestone
Release 3.11.4
Development

Successfully merging this pull request may close these issues.
3 participants
@nlohmann @coveralls @gregmarr