Fix scoping of assoc_func in OCSort.cpp and use assoc_func in update code #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix scoping for assoc_func, and replace usages of giou_batch with assoc_func to make it actually useful for changing how the code associates tracks and detections. A more in-depth change to the associate function in Association.hpp might be also needed, but would require refactoring the function's arguments and I didn't want to make a breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The std:function assoc_func is declared both in the class definition and the class constructor of OCSort. Fix scoping for assoc_func, by changing the declaration in the constructor to an instantiation, and replace usages of giou_batch with assoc_func to make it useful for changing how the code associates tracks and detections. A more in-depth change to the associate function in Association.hpp might be also needed, but would require refactoring the function's arguments and I didn't want to make a breaking change.