Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[quant] Prevent faketensoring shape values #144

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

rsuderman
Copy link
Contributor

All numpy arrays are automatically converted to fake tensors. To support reshape constants we need to ensure that they are cast to integers first.

Copy link
Contributor

@stellaraccident stellaraccident left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ffs. I'm sorry. That must have really hurt to find. Thank you.

All numpy arrays are automatically converted to fake tensors. To support
reshape constants we need to ensure that they are cast to integers
first.
@rsuderman rsuderman merged commit 040761c into nod-ai:main Aug 24, 2024
4 checks passed
@rsuderman rsuderman deleted the fix_quant_export branch August 24, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants