Pin IREE to specific version #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottTodd
approved these changes
Sep 4, 2024
| @@ -46,6 +47,7 @@ jobs: | |||
| repository: iree-org/iree | |||
| path: ${{ env.IREE_REPO_DIR }} | |||
| submodules: false | |||
| ref: ${{ env.IREE_REF }} | |||
There was a problem hiding this comment.
Any particular reason to store this in an environment variable instead of inlining it?
Suggested change
| ref: ${{ env.IREE_REF }} | |
| ref: candidate-20240904.1006 |
Unless using it in multiple places, I'd prefer to save the one line of code :D
There was a problem hiding this comment.
The intention was to make have this and well as other vars grouped and near to the top to make it more convenient to update these. But no strong feeling.
There was a problem hiding this comment.
Gotcha. I see your point, but I also like to having some of that local to the actions/checkout step. Not a big deal either way.
There was a problem hiding this comment.
I removed the environment variable and moved it to the action :)
Pins IREE checkout in the CI or obtained via FetchContent to the same specified version. Furthermore, installs the iree-compiler in the CI.
ScottTodd
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pins IREE checkout in the CI or obtained via FetchContent to the same specified version. Furthermore, installs the iree-compiler in the CI.