Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable strictness for export of llama #168

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Disable strictness for export of llama #168

merged 3 commits into from
Sep 6, 2024

Conversation

rsuderman
Copy link
Contributor

Strictness validates correctness but this results in loading the tensors to memory. Disabling helps with export speed.

@rsuderman
Disable strictness for export of llama
9213468 
Strictness validates correctness but this results in loading the tensors
to memory. Disabling helps with loading speed.
stellaraccident
stellaraccident approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@stellaraccident stellaraccident left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like there's an issue to file here on the PyTorch side. It isn't clear to me that the overhead ballooning is intended on their side, and if you can describe the issue/have a simplified reproducer, it might help them.

@rsuderman rsuderman merged commit a038133 into nod-ai:main Sep 6, 2024
7 checks passed
@rsuderman rsuderman deleted the enable_strictness branch September 6, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stellaraccident stellaraccident stellaraccident approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rsuderman @stellaraccident