Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor app_tests/integration_tests/llm for easy addition of more models for testing #728

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

renxida
Copy link
Contributor

@renxida renxida commented Dec 26, 2024

Bundled up loose parameter passing in the testing infra to support support easily adding models from HF, Azure, and local like:

TEST_MODELS = {
    "open_llama_3b": ModelConfig(
        source=ModelSource.HUGGINGFACE,
        repo_id="SlyEcho/open_llama_3b_v2_gguf",
        model_file="open-llama-3b-v2-f16.gguf",
        tokenizer_id="openlm-research/open_llama_3b_v2",
        batch_sizes=(1, 4),
        device_settings=device_settings.CPU,
    ),
    "llama3.1_8b": ModelConfig(
        source=ModelSource.LOCAL,
        local_path=Path("/data/llama3.1/8b/llama8b_f16.irpa"),
        model_file="llama8b_f16.irpa",
        tokenizer_id="NousResearch/Meta-Llama-3.1-8B",
        batch_sizes=(1, 4),
        device_settings=device_settings.CPU,
    ),
    "azure_llama": ModelConfig(
        source=ModelSource.AZURE,
        azure_config=AzureConfig(
            account_name="sharkblobs",
            container_name="halo-models",
            blob_path="llm-dev/llama3_8b/8b_f16.irpa",
        ),
        model_file="azure-llama.irpa",
        tokenizer_id="openlm-research/open_llama_3b_v2",
        batch_sizes=(1, 4),
        device_settings=device_settings.CPU,
    ),
}

Sharktank has a similar list of models in hf_datasets.py that only supports huggingface.

Might be of interest to draw from that at some point.

@renxida renxida force-pushed the llama3-integration-tests branch 3 times, most recently from 160cc65 to 7dcd21d Compare January 6, 2025 19:26
@renxida renxida force-pushed the llama3-integration-tests branch from 83a0626 to 188ff8f Compare January 13, 2025 16:46
@renxida renxida changed the title Add meta llama 3 ci test using local irpa on CI machine Refactor app_tests/integration_tests/llm for easy addition of more models for testing Jan 13, 2025
@renxida renxida force-pushed the llama3-integration-tests branch from 188ff8f to 1074257 Compare January 13, 2025 16:47
@renxida
Copy link
Contributor Author

renxida commented Jan 13, 2025

BTW CI is actually passing, I just forgot to re-xfail the concur tests we previously xfailed.

@renxida renxida marked this pull request as ready for review January 13, 2025 17:41
@renxida renxida requested a review from stbaione January 13, 2025 17:41
@renxida renxida requested a review from stbaione January 13, 2025 21:38
@renxida renxida force-pushed the llama3-integration-tests branch from 8a44531 to b324cde Compare January 14, 2025 04:52
@renxida renxida requested a review from stbaione January 14, 2025 05:16
@renxida renxida enabled auto-merge (squash) January 14, 2025 11:55
@renxida renxida merged commit 946fb7c into nod-ai:main Jan 14, 2025
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants