Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-raise exception after logging it in SDXL test. #766

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Re-raise exception after logging it in SDXL test. #766

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions shortfin/tests/apps/sd/e2e_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,7 @@ def send_json_file(url="http://0.0.0.0:8000", num_copies=1):

except requests.exceptions.RequestException as e:
print(f"Error sending the request: {e}")
raise e
Comment on lines 233 to +235
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, the Exception seems pretty noisy when raised as-is. Could at least raise a new Exception instead of proceeding though.

https://github.com/nod-ai/shark-ai/actions/runs/12642399694/job/35226615224?pr=766#step:7:271

WDYT, @monorimet ?


return imgs, response.status_code

Expand Down
Loading