Switch workflows to use new requirements-iree-*.txt files. #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archana-ramalingam
approved these changes
Jan 10, 2025
marbre
reviewed
Jan 13, 2025
| pip install --no-compile -r pytorch-cpu-requirements.txt | ||
| pip install -r requirements-iree-unpinned.txt | ||
| pip install --no-compile \ | ||
| -r sharktank/requirements-tests.txt \ |
There was a problem hiding this comment.
I'm not following here. What change do you want made?
I believe
pip install --no-compile \
-r sharktank/requirements-tests.txt \
-e sharktank/
is sufficient, no need to also install sharktank/requirements.txt or sharktank/requirements-dev.txt
There was a problem hiding this comment.
As commented above with this, this drops installing the dependencies specified in sharktank/requirements-dev.txt. Just wanted to point out that this is the same here but that might have been a little to short. No change needed.
stbaione
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #760. We could make the scheduled jobs test both pinned and unpinned versions like on #767.
Cleanup included here:
requirements.txtin some workflows, instead opting to just install from the more specificsharktank/requirements-tests.txtI did not test the changes to scheduled workflows. Could do that on request, or just revert if we see issues.