[tuner] add the output file #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangtianliu
force-pushed
the
tune_output
branch
from
49bea8d to
261ad2e
Compare
kuhar
requested changes
Jan 13, 2025
bangtianliu
force-pushed
the
tune_output
branch
from
083ca1c to
41dd78c
Compare
bangtianliu
force-pushed
the
tune_output
branch
2 times, most recently
from
61b965b to
e62d2c5
Compare
kuhar
reviewed
Jan 13, 2025
|
Instead of opening a plaintext file, we can have multiple loggers configured with different logging level, such that the summary log contains only the most important messages: https://docs.python.org/3/howto/logging-cookbook.html#logging-to-multiple-destinations |
bangtianliu
force-pushed
the
tune_output
branch
from
e62d2c5 to
19f6a2a
Compare
bangtianliu
force-pushed
the
tune_output
branch
4 times, most recently
from
f4b01ab to
fbe3d30
Compare
kuhar
reviewed
Jan 14, 2025
kuhar
reviewed
Jan 14, 2025
|
bangtianliu
force-pushed
the
tune_output
branch
from
081eef9 to
a131e75
Compare
Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
bangtianliu
force-pushed
the
tune_output
branch
from
a131e75 to
c51351a
Compare
kuhar
reviewed
Jan 14, 2025
Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
bangtianliu
force-pushed
the
tune_output
branch
from
d13ec6a to
16b4697
Compare
kuhar
reviewed
Jan 14, 2025
Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the task described in #806.
It adds a separate output file to the tuner to summarize the most important information, such as the top candidates (dispatch and model) and paths to their specifications.
Also, it fixes the issue with incorrect reporting of the compilation success rate in the log.