-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update review_guidelines.md #47
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
I feel that we should probably need some criteria for what can be posted - in case people game the system and try to amplify ads and then it would be somewhat awkward to say no. But we can add a general sentence that it should be reviewed/proof-read by a TSC member. |
@@ -5,4 +5,5 @@ The review guidelines are currently under discussions. | |||
Currently, only the following automated Bluesky content is allowed: | |||
|
|||
- Posting of release announcements, or reposts of release announcements posted by releasers. | |||
- Posts and Reposts of new features / website content / requests for community help or engagement, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Posts and Reposts of new features / website content / requests for community help or engagement, etc. | |
- Posts and Reposts of new features / website content / requests for community help or engagement, etc. | |
- Should be proof-read/reviewed by at least 1 TSC member before being reposted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should clarify if we mean "at least x TSC voting members" or "a TSC motion"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think 1 is enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should say "TSC voting member". I've added Triage role to @nodejs/tsc
so we can request a review from the team
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO regular is also fine, just people who have been staying with the project for long enough to be trust-worthy to some extent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you also be fine with using "voting members" or "member of @nodejs/tsc
"?
See conversation in #44