Make sure that INCS_* vars are properly escaped
#280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, there was a chance that gyp-next would generate broken Make files. Specifically, if the path to the project that you’re building contains spaces, then the INCS_* Make variables would look like this: INCS_Debug := \ -I/home/jayman/Documents/Home/VC/Git/Partially mine/node/repo/out/Debug/addons_headers/include/node \ -I/home/jayman/Documents/Home/VC/Git/Partially mine/node/repo/out/Debug/addons_headers/src \ -I/home/jayman/Documents/Home/VC/Git/Partially mine/node/repo/out/Debug/addons_headers/deps/openssl/config \ -I/home/jayman/Documents/Home/VC/Git/Partially mine/node/repo/out/Debug/addons_headers/deps/openssl/openssl/include \ -I/home/jayman/Documents/Home/VC/Git/Partially mine/node/repo/out/Debug/addons_headers/deps/uv/include \ -I/home/jayman/Documents/Home/VC/Git/Partially mine/node/repo/out/Debug/addons_headers/deps/zlib \ -I/home/jayman/Documents/Home/VC/Git/Partially mine/node/repo/out/Debug/addons_headers/deps/v8/include This would eventually cause builds to fail because the spaces in the paths weren’t properly escaped. This change makes sure that the paths get properly escaped.
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main motivation behind this pull request is to make gyp-next do the right thing, even if the path to the project that you’re building contains spaces. See the commit message for details.
How to test this pull request
Make sure that you have all of the prerequisites for building Node.js with Ninja. (I’ve been able to put Node.js into a directory that contains spaces and build it with Ninja. I haven’t been able to do the same without Ninja yet.)
Make sure that you have Wget installed.
Make sure that you have a clone of the
noderepository, and that the path to the clone of your Node.js repo contains spaces.Change directory into your
noderepository.Create a new branch for a pull request that I made by running this command:
The fixes from that other pull request are necessary or else the build won’t get far enough in order to test the changes that are in this pull request.
Switch to the branch that you just created by running this command:
Try to build and test Node.js by running these commands:
The final
make test-onlycommand will fail to build.Download this pull request as a patch by running this command:
Apply this patch to the vendored dependency that’s in the
noderepo by running this command:Delete the patch file by running this command:
Try to build and test Node.js by running these commands:
At this point, the final
make test-onlycommand will successfully build, but (for me at least) one or more of the actual tests will fail once it’s run.There’s almost certainly a better way to test out this pull request, but this is the best that I can come up with given the fact that I don’t really know anything about Node.js or gyp-next. If anyone can come up with a better or easier way to test out this pull request, then that would be helpful.