esm: fix jsdoc type refs to ModuleJobBase in esm/loader
#56499
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakobJingleheimer
added
the
fast-track
|
Review requested:
|
|
Fast-track has been requested by @JakobJingleheimer. Please 👍 to approve. |
nodejs-github-bot
added
esm
JakobJingleheimer
force-pushed
the
esm/fix-jsdoc-getModuleJobForImport
branch
from
c36c95d to
fac3717
Compare
JakobJingleheimer
changed the title
getModuleJobForImportModuleJobBase in esm/loader
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56499 +/- ##
==========================================
- Coverage 89.12% 89.12% -0.01%
==========================================
Files 662 662
Lines 191555 191556 +1
Branches 36856 36862 +6
==========================================
- Hits 170730 170729 -1
+ Misses 13696 13688 -8
- Partials 7129 7139 +10
|
jasnell
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.