-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: enable type checking within the internal/modules
directory
#56500
base: main
Are you sure you want to change the base?
tools: enable type checking within the internal/modules
directory
#56500
Conversation
Review requested:
|
Type checking on JS files is not a nice experience -- to write types in JSDoc is sophisticated and making it enforced could lead to more sophisticated types and labor work in JSDoc to pass the check. I would prefer type stripping if enabling proper type check and a robust code base is what we eventually want. node/lib/internal/modules/esm/utils.js Lines 104 to 139 in 36c53c6
|
I don't mind the jsdocs + type-checking (I use it in a couple projects). If we're open to type-stripping, that would be better! But a much more radical change I did not expect would get support. |
internal/modules
Let's use a commit message that makes it clear this is internal only, as is I thought you meant "in users' |
2dbe9b5
to
36ed7be
Compare
internal/modules
internal/modules
directory
This enables us to find the current type issues within the modules subsystem. There are quite a few.
Not sure if we should:
Perhaps we can eventually make this a CI check.