test: mark test-http-server-request-timeouts-mixed as flaky #56503
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been flaking the CI for more than 2 years with various attempts to fix without success. It has still been flaking the CI (failed 19 out of 100 recent testing CI runs). It's time to mark it as flaky.
nodejs-github-bot
added
needs-ci
richardlau
approved these changes
Jan 7, 2025
github-actions
bot
removed
the
request-ci
jasnell
approved these changes
Jan 7, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56503 +/- ##
==========================================
+ Coverage 88.52% 89.12% +0.60%
==========================================
Files 660 662 +2
Lines 190900 191555 +655
Branches 36631 36861 +230
==========================================
+ Hits 168998 170728 +1730
+ Misses 15097 13692 -1405
- Partials 6805 7135 +330 |
lpinca
approved these changes
Jan 7, 2025
jakecastelli
approved these changes
Jan 8, 2025
jakecastelli
added
the
author ready
joyeecheung
added
the
commit-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been flaking the CI for more than 2 years with various attempts to fix without success. It has still been flaking the CI (failed 19 out of 100 recent testing CI runs). It's time to mark it as flaky.
Refs: #43465