Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: fix symbol name and mark experimental new process methods #56517

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 8, 2025

The methods landed (and were released 😞) with two shortcomings:

  • The added methods were not marked as experimental.
  • The symbol name they used did not follow our conventions:
    In the Node.js runtime we prefix all our global symbols with `nodejs.`,
    e.g. `Symbol.for('nodejs.hello')`.

Refs: #56400 (comment)

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.17%. Comparing base (ea493c1) to head (8a70467).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56517      +/-   ##
==========================================
+ Coverage   89.12%   89.17%   +0.04%     
==========================================
  Files         662      662              
  Lines      191575   191585      +10     
  Branches    36867    36864       -3     
==========================================
+ Hits       170740   170843     +103     
+ Misses      13698    13607      -91     
+ Partials     7137     7135       -2     
Files with missing lines Coverage Δ
lib/internal/process/per_thread.js 99.32% <100.00%> (+<0.01%) ⬆️

... and 52 files with indirect coverage changes

@marco-ippolito marco-ippolito changed the title process: fix symbol name and mark experiemental new process methods process: fix symbol name and mark experimental new process methods Jan 8, 2025
@aduh95 aduh95 force-pushed the experimental-process-ref-and-unref branch from cb522b9 to 8a70467 Compare January 8, 2025 18:53
@aduh95 aduh95 requested a review from jasnell January 8, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants