Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Migrate ContextifyContext to cppgc #56522

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Jan 8, 2025

This simplifies the memory management of ContextifyContext, making all the references known to V8's GC.

Depends on #56534

@joyeecheung joyeecheung marked this pull request as draft January 8, 2025 17:44
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 76.47059% with 8 lines in your changes missing coverage. Please review.

Project coverage is 89.17%. Comparing base (7c3aa9f) to head (547062e).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/node_contextify.cc 65.00% 7 Missing ⚠️
src/node_contextify.h 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56522      +/-   ##
==========================================
+ Coverage   89.12%   89.17%   +0.04%     
==========================================
  Files         662      662              
  Lines      191556   191589      +33     
  Branches    36860    36863       +3     
==========================================
+ Hits       170732   170846     +114     
+ Misses      13690    13601      -89     
- Partials     7134     7142       +8     
Files with missing lines Coverage Δ
src/api/embed_helpers.cc 74.75% <100.00%> (+0.12%) ⬆️
src/env.cc 85.63% <100.00%> (-0.04%) ⬇️
src/env.h 98.14% <ø> (ø)
src/node_main_instance.cc 90.27% <100.00%> (ø)
src/node_worker.cc 83.46% <100.00%> (-0.49%) ⬇️
src/node_contextify.h 85.71% <50.00%> (+12.38%) ⬆️
src/node_contextify.cc 81.48% <65.00%> (+0.11%) ⬆️

... and 56 files with indirect coverage changes

@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 9, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 9, 2025
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants