Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: replace pull_request_target to pull_request #56536

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

tools: replace pull_request_target to pull_request #56536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/comment-labeled.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Comment on issues and PRs when labeled
on:
issues:
types: [labeled]
pull_request_target:
pull_request:
types: [labeled]

env:
Expand Down Expand Up @@ -35,7 +35,7 @@ jobs:
fast-track:
permissions:
pull-requests: write
if: github.repository == 'nodejs/node' && github.event_name == 'pull_request_target' && github.event.label.name == 'fast-track'
if: github.repository == 'nodejs/node' && github.event_name == 'pull_request' && github.event.label.name == 'fast-track'
runs-on: ubuntu-latest
steps:
- name: Request Fast-Track
Expand All @@ -46,7 +46,7 @@ jobs:
notable-change:
permissions:
pull-requests: write
if: github.repository == 'nodejs/node' && github.event_name == 'pull_request_target' && github.event.label.name == 'notable-change'
if: github.repository == 'nodejs/node' && github.event_name == 'pull_request' && github.event.label.name == 'notable-change'
runs-on: ubuntu-latest
steps:
- name: Add notable change description
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/label-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Label PRs

on:
pull_request_target:
pull_request:
types: [opened]

permissions:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/notify-on-review-wanted.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Notify on Review Wanted
on:
issues:
types: [labeled]
pull_request_target:
pull_request:
types: [labeled]

permissions:
Expand Down
2 changes: 1 addition & 1 deletion doc/contributing/commit-queue.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ reasons:
the last one to finish will fail because the local branch will be out of
sync with the remote after the first Action pushes. `issue_comment` event
has the same limitation.
2. `pull_request_target` will only run if the Action exists on the base commit
2. `pull_request` will only run if the Action exists on the base commit
of a pull request, and it will run the Action version present on that
commit, meaning we wouldn't be able to use it for already opened PRs
without rebasing them first.
Expand Down
Loading