Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure code elements within links display correct link styling (#7339) #7386

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

mpruser
Copy link
Contributor

@mpruser mpruser commented Jan 4, 2025

Description

ensure code elements within links display correct link styling

  • Adjusted CSS specificity to ensure code elements within links inherit link styling.
  • This change addresses the issue where code elements inside links did not appear as links, improving visual consistency and accessibility.

Validation

Before After
스크린샷 2025-01-04 오후 3 07 52 스크린샷 2025-01-04 오후 3 07 43

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.

@mpruser mpruser requested a review from a team as a code owner January 4, 2025 06:30
Copy link

vercel bot commented Jan 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jan 4, 2025 6:31am

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 94 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 88%
87.1% (736/845) 72.13% (233/323) 86.33% (139/161)

Unit Test Report

Tests Skipped Failures Errors Time
185 0 💤 0 ❌ 0 🔥 5.447s ⏱️

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Jan 6, 2025
Merged via the queue into nodejs:main with commit 4b710a9 Jan 6, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants