Enable OPTIONS preflight and a method to enable cros origins #359
Conversation
|
tests are failing |
index.js
Outdated
| @@ -136,7 +139,7 @@ function initializeServer(config) { | |||
| // Add a parser for application/x-www-form-urlencoded | |||
| server.addContentTypeParser( | |||
| 'application/x-www-form-urlencoded', | |||
| function(_, payload, done) { | |||
| function (_, payload, done) { | |||
index.js
Outdated
| @@ -156,7 +159,7 @@ function initializeServer(config) { | |||
| server.addContentTypeParser( | |||
| '*', | |||
| { parseAs: 'buffer' }, | |||
| function(req, body, done) { | |||
| function (req, body, done) { | |||
lib/invoker.js
Outdated
| 'access-control-allow-methods': | ||
| 'OPTIONS, GET, DELETE, POST, PUT, HEAD, PATCH', | ||
| 'access-control-allow-origin': '*' | ||
| 'access-control-allow-methods': 'OPTIONS, GET, POST', |
There was a problem hiding this comment.
why are you removing the other methods(DELETE, PUT, HEAD, PATCH)? This should stay the same since it is the default, otherwise it would be a breaking change
There was a problem hiding this comment.
invocation-handler.js
module.exports = function use(fastify, opts, done) {
fastify.get('/', doGet);
fastify.post('/', doPost);
fastify.options('/', doOptions);
const invokeFunction = invoker(opts);As you can see here, only the post and get were supported and now i added options. Why should the rest of the methods be allowed if they cannot be used? Anyway, I added the rest of allowed methods in cors.
|
@lholmquist I fixed the code, according to the tests and removed formatting differences. Can you take another look? Thanks |
|
Hello @lholmquist , can you take a look at this PR? |
|
@giurgiur99 can you please add a test/tests for this new functionality? |
|
@lholmquist I added tests for preflight and allowed origins |
Reasoning
Changes