Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dereference of undefined #363

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

matejvasek
Copy link
Contributor

  • Fixed dereference of undefined on fnReturn when user function does not return/returns undefined.

  • Fixed error in logging.

Fixed dereference of undefined on fnReturn when user function does not
return/returns undefined.

Fixed error in logging.

Signed-off-by: Matej Vašek <matejvasek@gmail.com>
Copy link
Member

@lholmquist lholmquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI was failing but it was becuase of contact the code cov thing, but the code fix is good

@lholmquist lholmquist merged commit 473a23f into nodeshift:main Oct 29, 2024
1 of 7 checks passed
Copy link

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth adding a test?

@lholmquist
Copy link
Member

Would it be worth adding a test?

I would not be opposed to that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants