Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: MessageTemplate 禁止访问私有属性 #2509

Merged
merged 7 commits into from
Jan 4, 2024

Conversation

mnixry
Copy link
Member

@mnixry mnixry commented Jan 1, 2024

To prevent potential information leak caused by format string injection.

to prevent potential information leak caused by format string injection
@mnixry mnixry added the enhancement New feature or request label Jan 1, 2024
@mnixry mnixry requested a review from yanyongyu January 1, 2024 07:58
Copy link

codecov bot commented Jan 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (90349dd) 92.07% compared to head (ee2dd1c) 92.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2509      +/-   ##
==========================================
+ Coverage   92.07%   92.09%   +0.02%     
==========================================
  Files          47       47              
  Lines        3594     3604      +10     
==========================================
+ Hits         3309     3319      +10     
  Misses        285      285              
Flag Coverage Δ
unittests 92.09% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 1, 2024

🚀 Deployed on https://deploy-preview-2509--nonebot2.netlify.app

@github-actions github-actions bot temporarily deployed to pull request January 1, 2024 08:03 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 1, 2024 08:09 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 1, 2024 08:36 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 1, 2024 09:12 Inactive
@yanyongyu yanyongyu added bug Something isn't working and removed enhancement New feature or request labels Jan 1, 2024
@yanyongyu yanyongyu changed the title Feat: Prevent accessing private attribute in MessageTemplate Fix: Prevent accessing private attribute in MessageTemplate Jan 1, 2024
@github-actions github-actions bot temporarily deployed to pull request January 1, 2024 09:32 Inactive
@yanyongyu yanyongyu changed the title Fix: Prevent accessing private attribute in MessageTemplate Fix: MessageTemplate 禁止访问私有属性 Jan 4, 2024
@yanyongyu yanyongyu merged commit b65b3b4 into master Jan 4, 2024
27 checks passed
@yanyongyu yanyongyu deleted the feature/prevent-dangerous-template-attr branch January 4, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants