Skip to content

Commit

Permalink
fix(CodecSelectionTest) Configure codec preference explicitly.
Browse files Browse the repository at this point in the history
Do not assume defaults since different deployments have different settings.
  • Loading branch information
jallamsetty1 committed Jun 20, 2024
1 parent 0eb82a1 commit 3f8e7a4
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions src/test/java/org/jitsi/meet/test/CodecSelectionTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ public void setupClass()
@Test
public void testAsymmetricCodecs()
{
ensureOneParticipant(getJitsiMeetUrl());
ensureOneParticipant(getJitsiMeetUrl()
.appendConfig("config.videoQuality.codecPreferenceOrder=[ 'VP9', 'VP8', 'AV1' ]"));
WebParticipant participant1 = getParticipant1();

WebParticipant participant2 = joinSecondParticipant(getJitsiMeetUrl()
Expand Down Expand Up @@ -153,7 +154,10 @@ public void testCodecSwitchOver()
{
hangUpAllParticipants();

ensureTwoParticipants();
JitsiMeetUrl url = getJitsiMeetUrl()
.appendConfig("config.videoQuality.codecPreferenceOrder=[ 'VP9', 'VP8', 'AV1' ]");

ensureTwoParticipants(url, url);
WebParticipant participant1 = getParticipant1();
WebParticipant participant2 = getParticipant2();

Expand All @@ -171,10 +175,10 @@ public void testCodecSwitchOver()
"return JitsiMeetJS.app.testing.isLocalCameraEncodingVp9();",
10);

JitsiMeetUrl url = getJitsiMeetUrl()
JitsiMeetUrl meetUrl = getJitsiMeetUrl()
.appendConfig("config.videoQuality.codecPreferenceOrder=[ 'VP8' ]");

WebParticipant participant3 = joinThirdParticipant(url, null);
WebParticipant participant3 = joinThirdParticipant(meetUrl, null);
participant3.waitToJoinMUC();
participant3.waitForIceConnected();
participant3.waitForSendReceiveData(true, true);
Expand Down

0 comments on commit 3f8e7a4

Please sign in to comment.