Add nonces to font-src and make NGINX replace "CSP_NONCE" with a nonce to ensure vite can handle it #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8e261c0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…e to deal with nonces Signed-off-by: MTRNord <mtrnord1@gmail.com>
Signed-off-by: Milton Moura <miltonmoura@gmail.com>
mgcm
force-pushed
the
fix-nonce-vite
branch
from
12ced85 to
8e261c0
Compare
HarHarLinks
reviewed
Sep 16, 2024
HarHarLinks
force-pushed
the
main
branch
2 times, most recently
from
fb28b97 to
ddc548c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CSP_NONCE allows use to set html.cspNonce in the vite config as the current approach in vite leads to invalid html. This way we can make sure that all included file tags have a nonce and not just the hardcoded ones. This also might help us with MUI later.
✔️ Checklist
Signed-off-byline in the message (more info).