Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make E3M4 format fully compliant with the OFP8 specification #10

Merged
merged 3 commits into from
Jun 2, 2024
Merged

Make E3M4 format fully compliant with the OFP8 specification #10

merged 3 commits into from
Jun 2, 2024

Conversation

mfasi
Copy link
Collaborator

@mfasi mfasi commented May 30, 2024

No description provided.

@mfasi
Restructure cpfloat_definition.h
f38d309 
**Breaking change**: the elements of the `cpfloat_softerr_t` enum have
been changed to be consistent with those of the other enums:
+ CPFLOAT_NO_SOFTERR -> CPFLOAT_SOFTERR_NO
+ CPFLOAT_FRAC_SOFTERR -> CPFLOAT_SOFTERR_FRAC
+ CPFLOAT_FP_SOFTERR -> CPFLOAT_SOFTERR_FP
mmikaitis
mmikaitis requested changes May 31, 2024
View reviewed changes
Copy link
Collaborator

@mmikaitis mmikaitis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Max, looks good! I left a few minor comments.

mex/cpfloat.c Outdated Show resolved Hide resolved
mex/cpfloat.c Outdated Show resolved Hide resolved
mex/cpfloat.m Outdated Show resolved Hide resolved
test/cpfloat_test.m Outdated Show resolved Hide resolved
@mmikaitis mmikaitis changed the title Add saturation mode for fully compliant OFP8 E3M4 format Add saturation mode for fully compliant OCP8 E3M4 format May 31, 2024
@mmikaitis mmikaitis changed the title Add saturation mode for fully compliant OCP8 E3M4 format Add saturation mode for fully compliant OFP8 E3M4 format May 31, 2024
@mfasi mfasi changed the title Add saturation mode for fully compliant OFP8 E3M4 format Make E3M4 format fully compliant with the OFP8 standard May 31, 2024
@mfasi mfasi force-pushed the dev branch 4 times, most recently from f076ce4 to 4aaf3de Compare June 1, 2024 06:17
@mfasi mfasi changed the title Make E3M4 format fully compliant with the OFP8 standard Make E3M4 format fully compliant with the OFP8 specification Jun 1, 2024
@mmikaitis
Copy link
Collaborator

Max, this looks good to me for main. Feel free to merge if you are happy with the changes.

@mfasi
Copy link
Collaborator Author

mfasi commented Jun 1, 2024

Thanks! I'll add some tests and, if everything goes well, merge.

@mfasi mfasi merged commit 9ae6e80 into main Jun 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmikaitis mmikaitis mmikaitis requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfasi @mmikaitis