Added Paypal NVP certificate authentication, updated specs

lib/paypal.rb

@@ -6,7 +6,7 @@
 require 'rest_client'
 
 module Paypal
-  mattr_accessor :api_version
+  mattr_accessor :api_version, :certificate_auth
   self.api_version = '88.0'
 
   ENDPOINT = {
@@ -20,7 +20,13 @@ module Paypal
 
   def self.endpoint
     if sandbox?
-      Paypal::ENDPOINT[:sandbox]
+      if certificate_auth?
+        Paypal::ENDPOINT[:sandbox_cert]
+      else
+        Paypal::ENDPOINT[:sandbox]
+      end
+    elsif certificate_auth?
+      Paypal::ENDPOINT[:production_cert]
     else
       Paypal::ENDPOINT[:production]
     end
@@ -56,6 +62,10 @@ def self.sandbox=(boolean)
   end
   self.sandbox = false
 
+  def self.certificate_auth?
+    @@certificate_auth
+  end
+
 end
 
 require 'paypal/util'

lib/paypal/nvp/request.rb

@@ -1,18 +1,26 @@
 module Paypal
   module NVP
     class Request < Base
-      attr_required :username, :password, :signature
-      attr_optional :subject
+      attr_required :username, :password
+      attr_optional :subject, :certificate, :signature
       attr_accessor :version
 
       ENDPOINT = {
         :production => 'https://api-3t.paypal.com/nvp',
-        :sandbox => 'https://api-3t.sandbox.paypal.com/nvp'
+        :production_cert => 'https://api.paypal.com/nvp',
+        :sandbox => 'https://api-3t.sandbox.paypal.com/nvp',
+        :sandbox_cert => 'https://api.sandbox.paypal.com/nvp'
       }
 
       def self.endpoint
         if Paypal.sandbox?
-          ENDPOINT[:sandbox]
+          if Paypal.certificate_auth?
+            ENDPOINT[:sandbox_cert]
+          else
+            ENDPOINT[:sandbox]
+          end
+        elsif Paypal.certificate_auth?
+          ENDPOINT[:production_cert]
         else
           ENDPOINT[:production]
         end
@@ -24,13 +32,16 @@ def initialize(attributes = {})
       end
 
       def common_params
-        {
+        params = {
           :USER => self.username,
           :PWD => self.password,
           :SIGNATURE => self.signature,
           :SUBJECT => self.subject,
           :VERSION => self.version
         }
+
+        params.merge!(:SIGNATURE => self.signature) unless Paypal.certificate_auth
+        params
       end
 
       def request(method, params = {})
@@ -42,7 +53,18 @@ def request(method, params = {})
       private
 
       def post(method, params)
-        RestClient.post(self.class.endpoint, common_params.merge(params).merge(:METHOD => method))
+        request_params = {
+          :method => :post, 
+          :url => self.class.endpoint, 
+          :payload => common_params.merge(params).merge(:METHOD => method)
+        }
+
+        request_params.merge!({
+          :ssl_client_cert => OpenSSL::X509::Certificate.new(self.certificate),
+          :ssl_client_key  => OpenSSL::PKey::RSA.new(self.certificate)
+        }) if Paypal.certificate_auth?
+
+        RestClient::Request.execute(request_params)
       end
 
       def handle_response
@@ -61,4 +83,4 @@ def handle_response
       end
     end
   end
-end
+end

spec/helpers/fake_response_helper.rb

@@ -30,4 +30,4 @@ def request_to(endpoint, method = :get)
 end
 
 FakeWeb.allow_net_connect = false
-include FakeResponseHelper
+include FakeResponseHelper

spec/paypal/express/request_spec.rb

@@ -17,8 +17,7 @@ def post_with_logging(method, params)
   let :attributes do
     {
       :username => 'nov',
-      :password => 'password',
-      :signature => 'sig'
+      :password => 'password'
     }
   end
 

spec/paypal/nvp/request_spec.rb

@@ -4,8 +4,7 @@
   let :attributes do
     {
       :username => 'nov',
-      :password => 'password',
-      :signature => 'sig'
+      :password => 'password'
     }
   end
 
@@ -39,12 +38,28 @@
         client.class.endpoint.should == Paypal::NVP::Request::ENDPOINT[:production]
       end
 
+      it 'should setup certificate endpoint and version' do
+        Paypal.certificate_auth = true
+        client = Paypal::NVP::Request.new attributes
+        client.class.endpoint.should == Paypal::NVP::Request::ENDPOINT[:production_cert]
+        Paypal.certificate_auth = false
+      end
+
       it 'should support sandbox mode' do
         sandbox_mode do
           client = Paypal::NVP::Request.new attributes
           client.class.endpoint.should == Paypal::NVP::Request::ENDPOINT[:sandbox]
         end
       end
+
+      it 'should support cert sandbox mode' do
+        sandbox_mode do
+          Paypal.certificate_auth = true
+          client = Paypal::NVP::Request.new attributes.merge(certificate: '/path/to/cert.pem')
+          client.class.endpoint.should == Paypal::NVP::Request::ENDPOINT[:sandbox_cert]
+          Paypal.certificate_auth = false
+        end
+      end
     end
 
     context 'when optional parameters are given' do
@@ -113,4 +128,4 @@
       end
     end
   end
-end
+end