Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks for MuseScore 4.4 #7

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions movable-do.qml
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,12 @@
//
// License: http://www.gnu.org/licenses/gpl.html GPL version 2 or higher
//=============================================================================

import QtQuick 2.9
import QtQuick.Controls 2.2
import QtQuick.Layouts 1.1
import QtQuick.Dialogs 1.2

import MuseScore 3.0
import MuseScore.UiComponents 1.0
import Muse.UiComponents 1.0

MuseScore {

Expand All @@ -24,8 +22,16 @@ MuseScore {
description: "This plugin inserts movable do texts derived from the given tonality"
menuPath: "Plugins.MovableDo"

pluginType: "dialog"

requiresScore: true

width: exporterColumn.width + 30
height: exporterColumn.height + 30

//4.4 title: "Movable Do"
Component.onCompleted: {
if (mscoreMajorVersion >= 4) {
if (mscoreMajorVersion >= 4 && mscoreMinorVersion <= 3) {
title = "Movable Do";
}
}
Expand Down Expand Up @@ -310,13 +316,10 @@ MuseScore {
console.log("Running Movable Do")
} // end onRun

Dialog {
Item {
id: tonalityDialog
visible: true
title: qsTr("Movable Do")
width: form.width
height: form.height
contentItem: Rectangle {
anchors.fill: parent
Rectangle {
id: form
width: exporterColumn.width + 30
height: exporterColumn.height + 30
Expand Down