Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synthesis infra struct #87

Closed
wants to merge 21 commits into from
Closed

Synthesis infra struct #87

wants to merge 21 commits into from

Conversation

ShiriMoran
Copy link
Contributor

@ShiriMoran ShiriMoran commented Dec 15, 2024

skeleton for synthesis

@ShiriMoran ShiriMoran requested a review from adisos December 15, 2024 15:51
Copy link
Contributor

@adisos adisos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is all the exporting of fields from model and dfw just for printing ?
isn't the current printing functionality sufficient?
if not, why not add printing functions within these packages?

@ShiriMoran
Copy link
Contributor Author

ShiriMoran commented Dec 16, 2024

I believed that all these fields will have to be exported; but now I'm not so sure.
So lets close this PR, and later see what are the fields that needs to be exported

@ShiriMoran ShiriMoran closed this Dec 16, 2024
@ShiriMoran ShiriMoran reopened this Dec 19, 2024
@ShiriMoran ShiriMoran closed this Dec 19, 2024
@ShiriMoran ShiriMoran deleted the synthesisInfraStruct branch January 8, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants