Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain structs - should they be receivers of explain print functions #630

Open
ShiriMoran opened this issue Jun 17, 2024 · 0 comments
Open

Comments

@ShiriMoran
Copy link
Contributor

          Hi

I have a general comment, "who is the receiver" comment, it has two points:

  1. A good practice is to put all the function of a receiver in one file.
  2. the receiver is not just another parameter, the main context of the function should be the receiver itself
  3. if you still think it is better not to put a func in another file, at list put all the functions of the receiver together.

in this function, I understand why you do not want to put it in the function of detailedConn, the context of this function is explainability, not detailedConn. I dont think that detailedConn should be the receiver here, just a parameter.

Originally posted by @haim-kermany in #627 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants