Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

529 explain return path #627

Merged
merged 200 commits into from
Jun 24, 2024
Merged

529 explain return path #627

merged 200 commits into from
Jun 24, 2024

Conversation

ShiriMoran
Copy link
Contributor

No description provided.

haim-kermany
haim-kermany previously approved these changes Jun 17, 2024
@adisos
Copy link
Collaborator

adisos commented Jun 18, 2024

@ShiriMoran please add the issue referred to this PR, and a short description of this PR.

Copy link
Collaborator

@adisos adisos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few initial comments

====================================================================

Allowed connections from vsi3a-ky[10.240.30.5] to vsi1-ky[10.240.10.4]: All Connections
TCP respond is enabled on protocol: TCP src-ports: 1-50 dst-ports: 1-600
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TCP respond is enabled on protocol: TCP src-ports: 1-50 dst-ports: 1-600
TCP response is enabled on protocol: TCP src-ports: 1-50 dst-ports: 1-600

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

security group sg1-ky allows connection with the following allow rules
index: 4, direction: inbound, conns: protocol: all, remote: sg3-ky (10.240.30.5/32,10.240.30.6/32), local: 0.0.0.0/0

TCP respond partly enabled by the following rules:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TCP respond partly enabled by the following rules:
TCP response partly enabled by the following rules:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a test example where TCP response is not enabled at all? what is the output in such case?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a link to the output file for this test?
do you specify by which NACL it is blocked?

Copy link
Contributor Author

@ShiriMoran ShiriMoran Jun 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here
The blocking NACL + rules are specified in debug ("Verbose") mode.

Not sure we want to add a blocking path. In most cases it is redundant and having such a path only in a small subset of the cases may be confusing. Lets discuss.

@ShiriMoran
Copy link
Contributor Author

ShiriMoran commented Jun 18, 2024

@ShiriMoran please add the issue referred to this PR, and a short description of this PR

Resolves #529 - adds responsive details in explainability

@adisos
Copy link
Collaborator

adisos commented Jun 18, 2024

@ShiriMoran please add the issue referred to this PR, and a short description of this PR

Resolve #529 - adds responsive details in explainability

If this issue should be closed with this PR, it should also be linked to this PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a variation of this test, where both rules from src-to-dst and rules from dst-to-src add constraints on permitted TCP ports , so intersection is validated from all ingress&egress rules of both directions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to push?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed now


Details:
~~~~~~~~
Path enabled by the following rules:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Path enabled by the following rules:
Path is enabled by the following rules:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

security group sg1-ky allows connection with the following allow rules
index: 4, direction: inbound, conns: protocol: all, remote: sg3-ky (10.240.30.5/32,10.240.30.6/32), local: 0.0.0.0/0

TCP response partly enabled by the following rules:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TCP response partly enabled by the following rules:
TCP response is partly enabled by the following rules:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ShiriMoran ShiriMoran merged commit a8faa5b into main Jun 24, 2024
4 checks passed
@ShiriMoran ShiriMoran deleted the 529_explain_return_path branch June 24, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explainability: add return path details for TCP connectivity
3 participants