Code

529 explain return path#627

Code

Merged

ShiriMoran merged 200 commits intomainnp-guard/vpc-network-config-analyzer:mainfrom 529_explain_return_pathnp-guard/vpc-network-config-analyzer:529_explain_return_pathCopy head branch name to clipboardJun 24, 2024

+4,818-583

Commits

Commits on May 27, 2024

• clarified comment

  ShiriMoran

  committed
  8677704

  Copy full SHA for 8677704

• clarified comment

  ShiriMoran

  committed
  bfc0a4d

  Copy full SHA for bfc0a4d

• added new structs and todos

  ShiriMoran

  committed
  f638b28

  Copy full SHA for f638b28

• renaming towards refactoring

  ShiriMoran

  committed
  df17381

  Copy full SHA for df17381

• minor refactoring

  ShiriMoran

  committed
  79ee2ed

  Copy full SHA for 79ee2ed

• minor refactoring

  ShiriMoran

  committed
  1b59966

  Copy full SHA for 1b59966

• implemented computeAllowedStatefulConnections to replace computeAllowedStatefulConnectionsOld

  ShiriMoran

  committed
  8d59bdd

  Copy full SHA for 8d59bdd

• new structs refactor

  ShiriMoran

  committed
  ff9c768

  Copy full SHA for ff9c768

• printing functions for the new structs

  ShiriMoran

  committed
  e7fe4b9

  Copy full SHA for e7fe4b9

Commits on May 28, 2024

• fix bug

  ShiriMoran

  committed
  c0f0c32

  Copy full SHA for c0f0c32

• grouping using new structs

  ShiriMoran

  committed
  7bfae63

  Copy full SHA for 7bfae63

• remove debug print

  ShiriMoran

  committed
  0f48c3d

  Copy full SHA for 0f48c3d

• added todo

  ShiriMoran

  committed
  1811764

  Copy full SHA for 1811764

• minor refactor

  ShiriMoran

  committed
  a60ebf0

  Copy full SHA for a60ebf0

• working tests

  ShiriMoran

  committed
  129b8d1

  Copy full SHA for 129b8d1

• added todos

  ShiriMoran

  committed
  7d8c7f8

  Copy full SHA for 7d8c7f8

Commits on May 29, 2024

• issues on loadBalancer understood and documented

  ShiriMoran

  committed
  962fa69

  Copy full SHA for 962fa69

• refactoring debug format (1)

  ShiriMoran

  committed
  0b893ff

  Copy full SHA for 0b893ff

• todo

  ShiriMoran

  committed
  4d7681d

  Copy full SHA for 4d7681d

• json format uses new struct; SplitAllowedConnsToUnidirectionalAndBidirectional no longer needed

  ShiriMoran

  committed
  bbe4e40

  Copy full SHA for bbe4e40

• debug format uses new struct

  ShiriMoran

  committed
  fa07330

  Copy full SHA for fa07330

• AllowedConnsCombinedStateful no longer used

  ShiriMoran

  committed
  965f9eb

  Copy full SHA for 965f9eb

• Added AllowedConnsCombinedStateful, its computation and using it for grouping

  ShiriMoran

  committed
  09ce513

  Copy full SHA for 09ce513

• json format for subnets uses new structs

  ShiriMoran

  committed
  f485708

  Copy full SHA for f485708

• now hasStatelessConns can use the new struct

  ShiriMoran

  committed
  7829f22

  Copy full SHA for 7829f22

• now ConnLabel can use the new struct and grouping's old groupedCommonProperties.conn is no longer required for report endpoints and report subnets

  ShiriMoran

  committed
  19f9c6f

  Copy full SHA for 19f9c6f

• func (connectivityMap GeneralConnectivityMap) getCombinedConnsStr() string no longer needed

  ShiriMoran

  committed
  48e252d

  Copy full SHA for 48e252d

• transforming grouping_test.go

  ShiriMoran

  committed
  67886c8

  Copy full SHA for 67886c8

Commits on May 30, 2024

• transforming grouping_test.go

  ShiriMoran

  committed
  16d8653

  Copy full SHA for 16d8653

• transforming grouping_test.go

  ShiriMoran

  committed
  c1d3ec9

  Copy full SHA for c1d3ec9

• transforming grouping_test.go

  ShiriMoran

  committed
  a70f5bd

  Copy full SHA for a70f5bd

• transforming grouping_test.go

  ShiriMoran

  committed
  ac7da41

  Copy full SHA for ac7da41

• replacing AllowedConnsCombined with AllowedConnsCombinedStateful

  ShiriMoran

  committed
  88c6f44

  Copy full SHA for 88c6f44

• replacing AllowedConnsCombined with AllowedConnsCombinedStateful

  ShiriMoran

  committed
  e2e248d

  Copy full SHA for e2e248d

• commenting not used (should be rewritten) code

  ShiriMoran

  committed
  8d66e85

  Copy full SHA for 8d66e85

• refactoring semantic diff to work with new structs

  ShiriMoran

  committed
  9f32cf5

  Copy full SHA for 9f32cf5

• refactoring subnets diff tests to work with new structs

  ShiriMoran

  committed
  294a00c

  Copy full SHA for 294a00c

• refactoring vsis diff tests to work with new structs

  ShiriMoran

  committed
  6932b97

  Copy full SHA for 6932b97

• renaming

  ShiriMoran

  committed
  a098f09

  Copy full SHA for a098f09

• added comment

  ShiriMoran

  committed
  ec0577e

  Copy full SHA for ec0577e

• AllowedConnsCombined no longer required in VPCConnectivity

  ShiriMoran

  committed
  37fa3d9

  Copy full SHA for 37fa3d9

• lint

  ShiriMoran

  committed
  2caa9c2

  Copy full SHA for 2caa9c2

• lint

  ShiriMoran

  committed
  714c1d4

  Copy full SHA for 714c1d4

• removed redundant todo

  ShiriMoran

  committed
  8190e25

  Copy full SHA for 8190e25

Commits on Jun 2, 2024

• merge with main

  ShiriMoran

  committed
  c25c542

  Copy full SHA for c25c542

• operations on ExtendedSet

  ShiriMoran

  committed
  d386048

  Copy full SHA for d386048

• using the operations where applicable

  ShiriMoran

  committed
  ed0bc3e

  Copy full SHA for ed0bc3e

Commits on Jun 3, 2024

• merge with main

  ShiriMoran

  committed
  ecf7dae

  Copy full SHA for ecf7dae

• removed non relevant todos

  ShiriMoran

  committed
  3606a03

  Copy full SHA for 3606a03

• removed redundant code

  ShiriMoran

  committed
  369b62c

  Copy full SHA for 369b62c

• removed AllowedConnsCombined from VPCsubnetConnectivity

  ShiriMoran

  committed
  a8c9078

  Copy full SHA for a8c9078

• refactored LB abstraction

  ShiriMoran

  committed
  2479faa

  Copy full SHA for 2479faa

• refactored LB abstraction

  ShiriMoran

  committed
  35b57af

  Copy full SHA for 35b57af

• non-stateful additions verified (before the abstraction ignored them)

  ShiriMoran

  committed
  23fd359

  Copy full SHA for 23fd359

• non-stateful additions verified (before the abstraction ignored them)

  ShiriMoran

  committed
  6030570

  Copy full SHA for 6030570

• single one stateful abstraction addition - nonstateful were not handled in abstraction before

  ShiriMoran

  committed
  693e569

  Copy full SHA for 693e569

• changes due to addition in * - verified (on some of the diffs)

  ShiriMoran

  committed
  3a29755

  Copy full SHA for 3a29755

• enabling all tests

  Show description for f2bc4d0
  ShiriMoran

  committed
  f2bc4d0

  Copy full SHA for f2bc4d0

Commits on Jun 4, 2024

• cosmetics

  ShiriMoran

  committed
  baff1fb

  Copy full SHA for baff1fb

• refactoring semantic diff leftovers

  ShiriMoran

  committed
  c2abe13

  Copy full SHA for c2abe13

• generics

  haim-kermany

  committed
  068fdae

  Copy full SHA for 068fdae

• revert generics which is deferred to a later PR

  ShiriMoran

  committed
  7458b44

  Copy full SHA for 7458b44

• rename

  ShiriMoran

  committed
  22ddf67

  Copy full SHA for 22ddf67

Commits on Jun 5, 2024

• CR: fix (e *ExtendedSet) Equal(other *ExtendedSet) bool

  Show description for 30a608b
  ShiriMoran

  committed
  30a608b

  Copy full SHA for 30a608b

• CR: ExtendedSet -> SetWithStateful

  ShiriMoran

  committed
  f5cf007

  Copy full SHA for f5cf007

• CR

  ShiriMoran

  committed
  dd14e47

  Copy full SHA for dd14e47

• CR

  ShiriMoran

  committed
  28eb3b5

  Copy full SHA for 28eb3b5

• CR: add NewStateWithStateful constructor and use it

  ShiriMoran

  committed
  5b0c3a9

  Copy full SHA for 5b0c3a9

• lint

  ShiriMoran

  committed
  1e1cf11

  Copy full SHA for 1e1cf11

• CR renaming

  ShiriMoran

  committed
  c08bdb1

  Copy full SHA for c08bdb1

• Merge branch 'main' into 255_stateful_connectivity_refactor

  ShiriMoran

  authored
  4dca3a2

  Copy full SHA for 4dca3a2

• added respondString() and todos

  ShiriMoran

  committed
  ad8de35

  Copy full SHA for ad8de35

• CR: renaming

  ShiriMoran

  committed
  6a2546e

  Copy full SHA for 6a2546e

• use constructor

  ShiriMoran

  committed
  70b7291

  Copy full SHA for 70b7291

• CR renaming

  ShiriMoran

  committed
  c02af67

  Copy full SHA for c02af67

• Merge remote-tracking branch 'origin/255_stateful_connectivity_refactor' into 255_stateful_connectivity_refactor

  ShiriMoran

  committed
  e342506

  Copy full SHA for e342506

• merge with main

  ShiriMoran

  committed
  0772fe3

  Copy full SHA for 0772fe3

• CR: avoid code duplication

  ShiriMoran

  committed
  9d619e7

  Copy full SHA for 9d619e7

• renaming

  ShiriMoran

  committed
  f8c6354

  Copy full SHA for f8c6354

• renaming

  ShiriMoran

  committed
  f1a57d1

  Copy full SHA for f1a57d1

• use constructors

  ShiriMoran

  committed
  a811a75

  Copy full SHA for a811a75

• CR: avoid code duplication

  ShiriMoran

  committed
  10e4c44

  Copy full SHA for 10e4c44

• renaming extendedConn -> connWithStateful

  ShiriMoran

  committed
  d7b9675

  Copy full SHA for d7b9675

• renaming extendedConn -> connWithStateful

  ShiriMoran

  committed
  d5cdcca

  Copy full SHA for d5cdcca

• CR

  ShiriMoran

  committed
  7fba540

  Copy full SHA for 7fba540

• CR: use constructor

  ShiriMoran

  committed
  28782aa

  Copy full SHA for 28782aa

• CR: use constructor

  ShiriMoran

  committed
  82dac8f

  Copy full SHA for 82dac8f

• renaming

  ShiriMoran

  committed
  5c6562c

  Copy full SHA for 5c6562c

Commits on Jun 6, 2024

• explainability should also use ConnWithStateful

  ShiriMoran

  committed
  eb803d4

  Copy full SHA for eb803d4

• Merge branch 'main' into 255_stateful_connectivity_refactor

  ShiriMoran

  authored
  9ae5f78

  Copy full SHA for 9ae5f78

• to avoid *** added spaces

  ShiriMoran

  committed
  697d64f

  Copy full SHA for 697d64f

• Merge remote-tracking branch 'origin/255_stateful_connectivity_refactor' into 255_stateful_connectivity_refactor

  ShiriMoran

  committed
  dfc0079

  Copy full SHA for dfc0079

• update unittest

  ShiriMoran

  committed
  bce123f

  Copy full SHA for bce123f

• update unittest

  ShiriMoran

  committed
  e42e816

  Copy full SHA for e42e816

• Merge branch 'main' into 255_stateful_connectivity_refactor

  ShiriMoran

  authored
  c7eb91d

  Copy full SHA for c7eb91d

• temp - commenting maintest, not related to this PR, that fails. Do not merge

  ShiriMoran

  committed
  fc2b4f1

  Copy full SHA for fc2b4f1

• temp - commenting maintest, not related to this PR, that fails. Do not merge

  ShiriMoran

  committed
  bb5b434

  Copy full SHA for bb5b434

• temp - commenting maintest, not related to this PR, that fails. Do not merge

  ShiriMoran

  committed
  3a721f1

  Copy full SHA for 3a721f1

• renaming

  ShiriMoran

  committed
  a48e8ec

  Copy full SHA for a48e8ec

Commits on Jun 7, 2024

• connWithStateful need not be exported

  ShiriMoran

  committed
  729268c

  Copy full SHA for 729268c

Commits on Jun 9, 2024

• non exporting functions that need to be exported (at the moment)

  ShiriMoran

  committed
  c5a471b

  Copy full SHA for c5a471b

• commets to Shiri

  haim-kermany

  committed
  abeef60

  Copy full SHA for abeef60

• added documentation

  ShiriMoran

  committed
  c991f05

  Copy full SHA for c991f05

• Merge remote-tracking branch 'origin/255_stateful_connectivity_refactor' into 255_stateful_connectivity_refactor

  Show description for 3cdb8f8
  ShiriMoran

  committed
  3cdb8f8

  Copy full SHA for 3cdb8f8

• merged with Haim's comments

  ShiriMoran

  committed
  e3b12aa

  Copy full SHA for e3b12aa

• unexport func that needs not be exported

  ShiriMoran

  committed
  260053f

  Copy full SHA for 260053f

• unexport func that needs not be exported

  ShiriMoran

  committed
  01936d3

  Copy full SHA for 01936d3

• CR renaming

  ShiriMoran

  committed
  7317d71

  Copy full SHA for 7317d71

• CR minor refactoring

  ShiriMoran

  committed
  5a28f3d

  Copy full SHA for 5a28f3d

• CR minor refactoring and doc adding

  ShiriMoran

  committed
  d5382b9

  Copy full SHA for d5382b9

• CR extracting detailConn code to a separate file

  ShiriMoran

  committed
  b1788dd

  Copy full SHA for b1788dd

• minor refactoring

  ShiriMoran

  committed
  d3b5919

  Copy full SHA for d3b5919

• bug fix

  ShiriMoran

  committed
  231ad25

  Copy full SHA for 231ad25

• bug fix

  ShiriMoran

  committed
  db8d8f8

  Copy full SHA for db8d8f8

• CR refactor

  ShiriMoran

  committed
  cb681e8

  Copy full SHA for cb681e8

• lint

  ShiriMoran

  committed
  4b25b51

  Copy full SHA for 4b25b51

• empy conn left out

  haim-kermany

  committed
  a8e2cbf

  Copy full SHA for a8e2cbf

• remove redundant (CR)

  ShiriMoran

  committed
  1147db2

  Copy full SHA for 1147db2

• Merge remote-tracking branch 'origin/255_stateful_connectivity_refactor' into 255_stateful_connectivity_refactor

  ShiriMoran

  committed
  2fdac9e

  Copy full SHA for 2fdac9e

• CR refactoring

  ShiriMoran

  committed
  d72d2a5

  Copy full SHA for d72d2a5

• unexported functions

  ShiriMoran

  committed
  9b26eb2

  Copy full SHA for 9b26eb2

• CR

  ShiriMoran

  committed
  684eeb3

  Copy full SHA for 684eeb3

• use String for allConn

  ShiriMoran

  committed
  827b31c

  Copy full SHA for 827b31c

• CR: enhanceString() of detailConn -> string()

  ShiriMoran

  committed
  d2b3a0d

  Copy full SHA for d2b3a0d

• CR: redundant code

  ShiriMoran

  committed
  4bcd64b

  Copy full SHA for 4bcd64b

• CR: redundant code

  ShiriMoran

  committed
  a1bd9ab

  Copy full SHA for a1bd9ab

• CR: renaming

  ShiriMoran

  committed
  43aca93

  Copy full SHA for 43aca93

• CR: renaming

  ShiriMoran

  committed
  7f05179

  Copy full SHA for 7f05179

• stateful -> responsive

  ShiriMoran

  committed
  466874d

  Copy full SHA for 466874d

• stateful -> responsive

  ShiriMoran

  committed
  1f8e1ab

  Copy full SHA for 1f8e1ab

• stateful -> responsive

  ShiriMoran

  committed
  41bd462

  Copy full SHA for 41bd462

• stateful -> responsive

  ShiriMoran

  committed
  0cc032a

  Copy full SHA for 0cc032a

• stateful -> responsive

  ShiriMoran

  committed
  772e2be

  Copy full SHA for 772e2be

• stateful -> responsive

  ShiriMoran

  committed
  a5cf61d

  Copy full SHA for a5cf61d

• stateful -> responsive

  ShiriMoran

  committed
  09f0553

  Copy full SHA for 09f0553

• update main test

  ShiriMoran

  committed
  0bf38b9

  Copy full SHA for 0bf38b9

• undo committed by mistake

  ShiriMoran

  committed
  cc717c7

  Copy full SHA for cc717c7

• remove committed by mistake

  ShiriMoran

  committed
  a77190d

  Copy full SHA for a77190d

Commits on Jun 10, 2024

• Merge remote-tracking branch 'origin/main' into 529_explain_return_path

  ShiriMoran

  committed
  112140c

  Copy full SHA for 112140c

• merge with main fix

  ShiriMoran

  committed
  15865d5

  Copy full SHA for 15865d5

• Merge branch '255_stateful_connectivity_refactor' into 529_explain_return_path

  ShiriMoran

  committed
  b9703c8

  Copy full SHA for b9703c8

• printing improvement

  ShiriMoran

  committed
  5c0a3fe

  Copy full SHA for 5c0a3fe

• use the full connection struct

  ShiriMoran

  committed
  4b4b8cc

  Copy full SHA for 4b4b8cc

• added documentation

  ShiriMoran

  committed
  e2fed91

  Copy full SHA for e2fed91

• added printing of return path

  ShiriMoran

  committed
  64b591a

  Copy full SHA for 64b591a

• returned path verified

  ShiriMoran

  committed
  4407845

  Copy full SHA for 4407845

• returned path verified

  ShiriMoran

  committed
  b2d30f6

  Copy full SHA for b2d30f6

• returned path verified

  ShiriMoran

  committed
  c55a0ea

  Copy full SHA for c55a0ea

• returned path verified

  ShiriMoran

  committed
  77d81a3

  Copy full SHA for 77d81a3

• returned path verified

  ShiriMoran

  committed
  6052796

  Copy full SHA for 6052796

• returned path verified

  ShiriMoran

  committed
  a2dcb67

  Copy full SHA for a2dcb67

• returned path verified

  ShiriMoran

  committed
  1d0d72d

  Copy full SHA for 1d0d72d

• returned path verified

  ShiriMoran

  committed
  5dc568c

  Copy full SHA for 5dc568c

• returned path verified

  ShiriMoran

  committed
  0b8da9c

  Copy full SHA for 0b8da9c

• returned path verified

  ShiriMoran

  committed
  3405c6d

  Copy full SHA for 3405c6d

• returned path verified

  ShiriMoran

  committed
  00f8c3d

  Copy full SHA for 00f8c3d

• returned path verified

  ShiriMoran

  committed
  cb58c83

  Copy full SHA for cb58c83

• returned path verified

  ShiriMoran

  committed
  784f46a

  Copy full SHA for 784f46a

• return path basic info print

  ShiriMoran

  committed
  0f836c6

  Copy full SHA for 0f836c6

• added structs for respond rules

  ShiriMoran

  committed
  2b0fc5f

  Copy full SHA for 2b0fc5f

• added computation of RespondRules still not checked

  ShiriMoran

  committed
  c192604

  Copy full SHA for c192604

Commits on Jun 11, 2024

• added computation of RespondRules still not checked

  ShiriMoran

  committed
  2251942

  Copy full SHA for 2251942

• preparation to group also by respondRules

  ShiriMoran

  committed
  226f0ad

  Copy full SHA for 226f0ad

• Added printing of respond path. Still needs to verify tests one by one are correct

  ShiriMoran

  committed
  0036c05

  Copy full SHA for 0036c05

Commits on Jun 13, 2024

• wording of printing header

  ShiriMoran

  committed
  becb133

  Copy full SHA for becb133

• only tcp rules are relevant for the response

  ShiriMoran

  committed
  f157d55

  Copy full SHA for f157d55

• added test of partly enabled respond

  ShiriMoran

  committed
  c5da48e

  Copy full SHA for c5da48e

• fix typo

  ShiriMoran

  committed
  08c6179

  Copy full SHA for 08c6179

• lint

  ShiriMoran

  committed
  38313be

  Copy full SHA for 38313be

• lint

  ShiriMoran

  committed
  f16b152

  Copy full SHA for f16b152

• merge with main

  ShiriMoran

  committed
  6347200

  Copy full SHA for 6347200

• clarified doc

  ShiriMoran

  committed
  8252cff

  Copy full SHA for 8252cff

• fix merge

  ShiriMoran

  committed
  7894059

  Copy full SHA for 7894059

• lint

  ShiriMoran

  committed
  17fe312

  Copy full SHA for 17fe312

Commits on Jun 17, 2024

• Merge branch 'main' into 529_explain_return_path

  ShiriMoran

  authored
  f4e70d2

  Copy full SHA for f4e70d2

• CR: use parm instead of receiver

  ShiriMoran

  committed
  b0c5f4c

  Copy full SHA for b0c5f4c

• Merge remote-tracking branch 'origin/529_explain_return_path' into 529_explain_return_path

  ShiriMoran

  committed
  36dbb70

  Copy full SHA for 36dbb70

• undoing CR change - should not be part of this PR (if we do it)

  ShiriMoran

  committed
  7f2dece

  Copy full SHA for 7f2dece

• CR- should not bea receiver

  ShiriMoran

  committed
  e141800

  Copy full SHA for e141800

• CR - have a documented func for hasTCPComponent()

  ShiriMoran

  committed
  ee528f6

  Copy full SHA for ee528f6

• CR - add documentation

  ShiriMoran

  committed
  27ab1af

  Copy full SHA for 27ab1af

• CR - add documentation

  ShiriMoran

  committed
  5bd3803

  Copy full SHA for 5bd3803

• CR - dup code into func

  ShiriMoran

  committed
  2c7af98

  Copy full SHA for 2c7af98

• minor reorgs

  ShiriMoran

  committed
  829d2c5

  Copy full SHA for 829d2c5

• CR

  ShiriMoran

  committed
  b09d0b3

  Copy full SHA for b09d0b3

• CR

  ShiriMoran

  committed
  0d02701

  Copy full SHA for 0d02701

• renaming

  haim-kermany

  committed
  f2fefe3

  Copy full SHA for f2fefe3

Commits on Jun 18, 2024

• Merge branch 'main' into 529_explain_return_path

  ShiriMoran

  authored
  eb8950d

  Copy full SHA for eb8950d

• CR: change wording

  ShiriMoran

  committed
  bb4ee46

  Copy full SHA for bb4ee46

• Merge remote-tracking branch 'origin/529_explain_return_path' into 529_explain_return_path

  ShiriMoran

  committed
  8cd4cd4

  Copy full SHA for 8cd4cd4

Commits on Jun 19, 2024

• merge with main

  ShiriMoran

  committed
  1510e5d

  Copy full SHA for 1510e5d

Commits on Jun 20, 2024

• switching src dst ports for responsive

  ShiriMoran

  committed
  b3c4e9f

  Copy full SHA for b3c4e9f

• partial respond test

  ShiriMoran

  committed
  06155e0

  Copy full SHA for 06155e0

• fine tuned cofig test file so that respond in the presence of different src and dst ports will be tested. The test failed and so a bug was fixed.

  ShiriMoran

  committed
  4026b2c

  Copy full SHA for 4026b2c

• wording

  ShiriMoran

  committed
  eff5896

  Copy full SHA for eff5896

• added test in which specific tcp ports are queried and this effects the respond path

  ShiriMoran

  committed
  3d17e34

  Copy full SHA for 3d17e34

Commits on Jun 24, 2024

• CR: wording

  ShiriMoran

  committed
  2a25276

  Copy full SHA for 2a25276

• CR: add test in which connection is partly in both directions

  ShiriMoran

  committed
  545e220

  Copy full SHA for 545e220

• enhance test

  ShiriMoran

  committed
  c330b87

  Copy full SHA for c330b87

• Merge branch 'main' into 529_explain_return_path

  ShiriMoran

  authored
  e1099dd

  Copy full SHA for e1099dd