aws public subnet explainability #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShiriMoran
requested changes
Aug 13, 2024
| @@ -206,6 +213,12 @@ func (g *groupedConnLine) explainPerCaseStr(c *VPCConfig, src, dst EndpointElem, | |||
| case crossVpcRouterRequired(src, dst) && crossVpcRouter != nil && crossVpcConnection.IsEmpty(): | |||
| return fmt.Sprintf("%vAll connections will be blocked since transit gateway denies route from source to destination"+tripleNLVars, | |||
| noConnection, headerPlusPath, details) | |||
| case isAtPrivateSubnet(dst) && src.IsExternal(): | |||
There was a problem hiding this comment.
The cases in which we provide a single line explaining why there is no connection should be minimized see #655. In this specific case we can provide full explainability and integrate the private subnet in the path and details.
We could defer the explanation part of this PR to latter PRs - I can take responsibility to this part.
There was a problem hiding this comment.
OK, will be resolved in another PR, by our explainability expert.
added a bullet to the relevant issue #756
There was a problem hiding this comment.
Perhaps better remove it all together
tests will be added in a different PR |
adisos
approved these changes
Aug 14, 2024
ShiriMoran
approved these changes
Aug 14, 2024
| @@ -206,6 +213,12 @@ func (g *groupedConnLine) explainPerCaseStr(c *VPCConfig, src, dst EndpointElem, | |||
| case crossVpcRouterRequired(src, dst) && crossVpcRouter != nil && crossVpcConnection.IsEmpty(): | |||
| return fmt.Sprintf("%vAll connections will be blocked since transit gateway denies route from source to destination"+tripleNLVars, | |||
| noConnection, headerPlusPath, details) | |||
| case isAtPrivateSubnet(dst) && src.IsExternal(): | |||
There was a problem hiding this comment.
Perhaps better remove it all together
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implementation of the first bullet of:
#756