Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add identifier validation to inc() #754

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: add identifier validation to inc() #754

wants to merge 2 commits into from

Conversation

mbtools
Copy link
Contributor

@mbtools mbtools commented Jan 21, 2025 •
edited
Loading

  • Adds a check of the identifier parameter for inc() when trying to increase pre-releases. This prevents the creation of an invalid semver.
  • Removes side-effects of inc() when it is throwing (it was changing the version)

Closes #349

@mbtools mbtools requested a review from a team as a code owner January 21, 2025 19:38
wraithgar
wraithgar reviewed Jan 21, 2025
View reviewed changes
classes/semver.js Outdated Show resolved Hide resolved
@mbtools mbtools mentioned this pull request Jan 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wraithgar wraithgar wraithgar left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] inc() may produce invalid semver with ReleaseType: prerelease
2 participants
@mbtools @wraithgar