Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: tap@21.0.1 #498

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

deps: tap@21.0.1 #498

wants to merge 11 commits into from

Conversation

reggi
Copy link
Contributor

@reggi reggi commented Dec 16, 2024

Resurfaces an old PR that updated tap 16 -> 19 (still not sure what's needed from that until i see the diff.
Had to do some googling to find why /* istanbul ignore next */ doesn't work anymore.

tapjs/tapjs#1027

got some node 22
failures - ENOENT: no such file or directory, open '/home/runner/work/template-oss/template-oss/.tap/fixtures/test-apply-esm.js-basic/file.js'

doesn't work on 20.5.0 because of tapjs/tapjs#1028

@reggi reggi requested a review from a team as a code owner December 16, 2024 16:51
@reggi reggi closed this Jan 23, 2025
@reggi reggi reopened this Jan 23, 2025
},
"templateOSS": {
"//@npmcli/template-oss": "This file is partially managed by @npmcli/template-oss. Edits may be overwritten.",
"publish": true,
"prettier": true
},
"engines": {
"node": "^18.17.0 || >=20.5.0"
"node": "^20.17.0 || >=22.9.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some digging cause I was wondering if this was a semver major. It's not.

~/D/n/c/b/gar_npx-cache (gar/npx-cache|✚1) $ npm view semver devDependencies["@npmcli/template-oss"]
4.22.0
~/D/n/c/b/gar_npx-cache (gar/npx-cache|✚1) $ npm view semver engines
{ node: '>=10' }
~/D/n/c/b/gar_npx-cache (gar/npx-cache|✚1) $ npm view @npmcli/template-oss@4.22.0 engines
{ node: '^18.17.0 || >=20.5.0' }

This got updated previously w/o a semver major. 4.0.0 was node 16 engines.

The last engines update was a feat. I asked the same question about engines there, and Luke answered it. Yay.

^20.17.0 is higher than >=20.5.0 so we're good there w/ all the packages that still have the node 18 engines entry.

Having sad all that, what are your thoughts on isolating the engines bump into a feat: commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants