fix(core): connections to daemon from plugin workers should not keep daemon alive #29540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit ec939fb.
☁️ Nx Cloud last updated this comment at |
FrozenPandaz
requested changes
Jan 9, 2025
| @@ -122,6 +123,8 @@ export class DaemonClient { | |||
| private _out: FileHandle = null; | |||
| private _err: FileHandle = null; | |||
|
|
|||
| private firstMessageSent = false; | |||
| @@ -153,7 +158,9 @@ const server = createServer(async (socket) => { | |||
| }); | |||
|
|
|||
| socket.on('close', () => { | |||
There was a problem hiding this comment.
I thought this only gets called when the client is destroyed?
The client won't be destroyed in the plugin worker right? Does this actually do anything at the moment?
|
Closing in favor of new strategy recommended by @FrozenPandaz |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The daemon uses ref counts to shut down automatically when it is not being actively used. Plugin workers are started by the daemon and shut down automatically when the daemon shuts down. If one of these plugins communicates with the daemon, a reference is counted. This plugin worker will not shut down until the daemon shuts down, so its socket will not be closed... so the daemon will stay alive.
Expected Behavior
Connections to the daemon from a plugin worker do not track a reference. More generally, connections from any source can unref themselves.
Related Issue(s)
Fixes #