fix(js): generate js libs with exports in package.json and ensure esm output when using rollup bundler #29565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 38b96b1.
☁️ Nx Cloud last updated this comment at |
leosvelperez
force-pushed
the
js/ts-setup-rollup-esm-and-exports
branch
from
e7a253c to
95ac511
Compare
jaysoo
reviewed
Jan 9, 2025
jaysoo
approved these changes
Jan 9, 2025
jaysoo
reviewed
Jan 9, 2025
jaysoo
force-pushed
the
js/ts-setup-rollup-esm-and-exports
branch
from
27cd475 to
d25fb37
Compare
FrozenPandaz
pushed a commit
that referenced
this pull request
Jan 15, 2025
… output when using rollup bundler (#29565) - Ensure libs are generated with `exports` in `package.json` - Generate `types` instead of `typings` in package.json - Update js lib with rollup to only output esm - Update `tsconfig.spec.json` for js libraries with rollup to set `module: esnext` and `moduleResolution: bundler` (they use `@swc/jest`) - Fix `@nx/js/typescript` issue with absolute paths when normalizing inputs/outputs - Fix `@nx/js/typescript` issue identifying buildable libs - Fix express app generator not installing `@types/express` <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # --------- Co-authored-by: Jack Hsu <jack.hsu@gmail.com> (cherry picked from commit dd9b09f)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exportsinpackage.jsontypesinstead oftypingsin package.jsontsconfig.spec.jsonfor js libraries with rollup to setmodule: esnextandmoduleResolution: bundler(they use@swc/jest)@nx/js/typescriptissue with absolute paths when normalizing inputs/outputs@nx/js/typescriptissue identifying buildable libs@types/expressCurrent Behavior
Expected Behavior
Related Issue(s)
Fixes #