Upgrade go #122
Merged
Upgrade go #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #77. Follows version policy change in nspcc-dev/.github#30. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Signed-off-by: Roman Khimov <roman@nspcc.ru>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #122 +/- ##
==========================================
- Coverage 59.35% 59.29% -0.06%
==========================================
Files 32 32
Lines 1823 1828 +5
==========================================
+ Hits 1082 1084 +2
- Misses 661 662 +1
- Partials 80 82 +2 ☔ View full report in Codecov by Sentry. |
AnnaShaleva
reviewed
Aug 12, 2024
Signed-off-by: Roman Khimov <roman@nspcc.ru>
Signed-off-by: Roman Khimov <roman@nspcc.ru>
Reuse slices if possible. Signed-off-by: Roman Khimov <roman@nspcc.ru>
It's supposed to be more efficient. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Signed-off-by: Roman Khimov <roman@nspcc.ru>
Signed-off-by: Roman Khimov <roman@nspcc.ru>
It shares the slice, so messing with it is a bad idea. Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
force-pushed
the
upgrade-go
branch
from
82a8d2f to
024a8cc
Compare
Less code, more fun. Signed-off-by: Roman Khimov <roman@nspcc.ru>
AnnaShaleva
approved these changes
Aug 12, 2024
AliceInHunterland
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.