Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

context: properly reset preBlock and preHeader #127

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

AnnaShaleva
Copy link
Member

I just don't believe it's possible, I was sure that I've added this resetting code. Required for https://github.com/bane-labs/go-ethereum/pull/287.

@AnnaShaleva AnnaShaleva added the bug Something isn't working label Aug 28, 2024
@AnnaShaleva AnnaShaleva added this to the v0.3.1 milestone Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.47%. Comparing base (d01dbcb) to head (9be6f21).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   59.42%   59.47%   +0.04%     
==========================================
  Files          32       32              
  Lines        1819     1821       +2     
==========================================
+ Hits         1081     1083       +2     
  Misses        659      659              
  Partials       79       79              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh. But consensus worked fine with blocks produced.

@roman-khimov roman-khimov merged commit b129031 into master Aug 28, 2024
12 checks passed
@roman-khimov roman-khimov deleted the fix-preblock-reset branch August 28, 2024 09:32
@AnnaShaleva
Copy link
Member Author

But consensus worked fine with blocks produced.

On real network I ended up in a stale proposal starting from the second block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants