Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: extend PreBlock processing callback #129

Merged
merged 5 commits into from
Sep 4, 2024

dbft: simplify PreBlock constructor

a6c5026
Select commit
Loading
Failed to load commit list.
Merged

*: extend PreBlock processing callback #129

dbft: simplify PreBlock constructor
a6c5026
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Sep 3, 2024 in 1s

59.25% (-0.22%) compared to d574d48

View this Pull Request on Codecov

59.25% (-0.22%) compared to d574d48

Details

Codecov Report

Attention: Patch coverage is 48.48485% with 17 lines in your changes missing coverage. Please review.

Project coverage is 59.25%. Comparing base (d574d48) to head (a6c5026).

Files with missing lines Patch % Lines
dbft.go 42.10% 8 Missing and 3 partials ⚠️
check.go 58.33% 4 Missing and 1 partial ⚠️
context.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
- Coverage   59.47%   59.25%   -0.22%     
==========================================
  Files          32       32              
  Lines        1821     1831      +10     
==========================================
+ Hits         1083     1085       +2     
- Misses        659      665       +6     
- Partials       79       81       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.