-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: take care of anti-MEV part #134
Conversation
AnnaShaleva
commented
Nov 11, 2024
•
edited
Loading
edited
- For anti-MEV extension it's possible that some commits carry invalid share which is impossible to check at the commit verification level. In this case node should collect some more commits. Hence, ProcessBlock callback signature is extended with error return value. The general idea is similar to PreBlock processing behaviour.
- Remove PreCommit with invalid signature from cache.
- Log Commit signature verification error.
- Add VerifyCommit callback.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #134 +/- ##
==========================================
- Coverage 58.61% 58.24% -0.37%
==========================================
Files 32 32
Lines 2235 2256 +21
==========================================
+ Hits 1310 1314 +4
- Misses 843 858 +15
- Partials 82 84 +2 ☔ View full report in Codecov by Sentry. |
@roman-khimov, review please, but simulation/CHANGELOG check are failing; will check what's happened with simulation. |
For anti-MEV extension it's possible that some commits carry invalid share which is impossible to check at the commit verification level. Signature shares verification happens inside ProcessBlock callback. If some of Commits contain invalid shares, the node should collect more commits. Hence, ProcessBlock callback is allowed to return an error. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
For better user experience. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
It's required by anti-MEV extension to perform state-independent TPKE signature verification. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
f77b768
to
be64b5f
Compare
Simulation is fixed by #135; CHANGELOG is updated. |