crypto/simulation: drop dead code and dependency #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need murmur3 to sort validators and we don't need serialization code since a129fd7. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #141 +/- ##
==========================================
- Coverage 58.49% 58.25% -0.24%
==========================================
Files 33 33
Lines 2279 2271 -8
==========================================
- Hits 1333 1323 -10
- Misses 861 863 +2
Partials 85 85 ☔ View full report in Codecov by Sentry. |
AnnaShaleva
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
LGTM, and I'm not sure if we need a changelog entry for it, there's no user-facing changes. @roman-khimov, agree to merge as is?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need murmur3 to sort validators and we don't need serialization code since a129fd7.