Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: get rid of github.com/nspcc-dev/neo-go/pkg/io dependency #89
*: get rid of github.com/nspcc-dev/neo-go/pkg/io dependency #89
Changes from all commits
15b3b3c
0c16b68
32c24ca
c8df9ff
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 104 in config.go
Codecov / codecov/patch
config.go#L104
Check warning on line 109 in config.go
Codecov / codecov/patch
config.go#L106-L109
Check warning on line 52 in payload/change_view.go
Codecov / codecov/patch
payload/change_view.go#L52
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only use them in tests, what if we're to move them into
_test.go
files? It'd avoid importingencoding/gob
for non-test builds.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The case is that we use them not only in tests, we also use them as default payloads for dBFT. So it won't be possible to easily integrate dBFT with Geth node without these default payloads.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Single-node Geth implementation used them before custom payloads implementation was added. Who knows, maybe one day we'll integrate dBFT with some other blockchain.
Check warning on line 42 in payload/commit.go
Codecov / codecov/patch
payload/commit.go#L42