Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

services: fix error check for NeoFS client Dial #3758

Merged
merged 2 commits into from
Dec 16, 2024
Merged

services: fix error check for NeoFS client Dial #3758

merged 2 commits into from
Dec 16, 2024

Conversation

AliceInHunterland
Copy link
Contributor

Close #3757

@AliceInHunterland
services: drop check of Unimplemented gRPC status in neofs helper
e741053 
NeoFS oracle can miss problem NeoFS server on dial. So `Unimplemented`
gRPC status should not be ignored.

Close #3757

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
@AliceInHunterland
services: refactor NeoFS client naming
f5ea79d 
There is just NeoFS client/conn.

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
@codecov Codecov
Copy link

codecov bot commented Dec 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.12%. Comparing base (9189b3e) to head (f5ea79d).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
pkg/services/helpers/neofs/neofs.go 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3758      +/-   ##
==========================================
+ Coverage   83.05%   83.12%   +0.07%     
==========================================
  Files         335      335              
  Lines       46748    46746       -2     
==========================================
+ Hits        38826    38859      +33     
+ Misses       6329     6291      -38     
- Partials     1593     1596       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cthulhu-rider
cthulhu-rider approved these changes Dec 16, 2024
View reviewed changes
go.mod Show resolved Hide resolved
@AnnaShaleva AnnaShaleva merged commit 24f81a7 into master Dec 16, 2024
33 of 34 checks passed
@AnnaShaleva AnnaShaleva deleted the sdk-fix branch December 16, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cthulhu-rider cthulhu-rider cthulhu-rider approved these changes

@AnnaShaleva AnnaShaleva AnnaShaleva approved these changes

@roman-khimov roman-khimov Awaiting requested review from roman-khimov roman-khimov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NeoFS oracle can miss problem NeoFS server on dial
3 participants
@AliceInHunterland @AnnaShaleva @cthulhu-rider