Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: update NeoFSBlockFetcher's ContainerID #3759

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

AliceInHunterland
Copy link
Contributor

No description provided.

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.12%. Comparing base (24f81a7) to head (6d50989).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3759      +/-   ##
==========================================
+ Coverage   83.07%   83.12%   +0.05%     
==========================================
  Files         335      335              
  Lines       46746    46746              
==========================================
+ Hits        38832    38857      +25     
+ Misses       6322     6293      -29     
- Partials     1592     1596       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AliceInHunterland AliceInHunterland marked this pull request as ready for review December 16, 2024 12:15
@AnnaShaleva AnnaShaleva added the config Configuration format update or breaking change label Dec 16, 2024
@AnnaShaleva AnnaShaleva added this to the v0.108.0 milestone Dec 16, 2024
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not merging this PR until we have these containers in a proper state.

Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Containers are well-maintained, mainnet sync is passed.

@AnnaShaleva AnnaShaleva merged commit cffafc4 into master Dec 20, 2024
34 checks passed
@AnnaShaleva AnnaShaleva deleted the container-update branch December 20, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config Configuration format update or breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants